Displaying 1 50 of 329,183 commits (0.047s)

FreeBSD — stable/11/sys/netinet in_pcb.c

MFC r331745 (by np):
  Fix RSS build (broken in r331309).

  Sponsored by: Chelsio Communications

PR:                227691
Pointy-hat to:        jtl
Delta File
+2 -2 stable/11/sys/netinet/in_pcb.c
+2 -2 1 file

FreeBSD — stable/10/release/arm GUMSTIX.conf PANDABOARD.conf, stable/11/release/arm RPI-B.conf BEAGLEBONE.conf

MFC r332674:
 Increase the msdosfs partition size on arm SoC images where the
 current size may not be sufficiently large for development and/or

PR:                227548
Sponsored by:        The FreeBSD Foundation

FreeBSD — head/sys/arm/conf SOCFPGA, head/sys/dts/arm socfpga_arria10_socdk_sdmmc.dts

Enable ARM PL330 DMA engine and Cadence Quad SPI flash controller on
Intel Arria 10 SoC boards.

Tested on Intel Arria 10 SoC Development Kit.

Sponsored by:        DARPA, AFRL

FreeBSD — head/sys/netinet6 icmp6.c

icmp6_reflect() sends ICMPv6 message with new IPv6 header. So, it is
considered as originated by our host packet. And thus rcvif should be
NULL, since it is used by ipfw(4) to determine that packet was originated
from this host. Some of icmp6_reflect() consumers reuse mbuf and m_pkthdr
without resetting rcvif pointer. To avoid this always reset m_pkthdr.rcvif
pointer to NULL in icmp6_reflect(). Also remove such line and comment
describing this from icmp6_error(), since it does not longer matters.

PR:                227674
Reported by:        eugen
MFC after:        1 week
Delta File
+1 -10 head/sys/netinet6/icmp6.c
+1 -10 1 file

FreeBSD — head/sys/conf files, head/sys/dev/flash cqspi.c n25q.c

Add driver for Cadence Quad SPI Flash Controller found on
Intel® Arria® 10 SoC.

Cadence Quad SPI Flash is not generic SPI controller, but SPI flash
controller, so don't use spibus here, instead provide quad spi flash

Since it is not on spibus, then mx25l flash device driver is not usable
here, so provide new n25q flash device driver with quad spi flash

Sponsored by:        DARPA, AFRL
Differential Revision:        https://reviews.freebsd.org/D10245

FreeBSD — stable/11/share/misc committers-src.dot

MFC r332386, r332430:
  Updated mentors information.
  Added entry in the correct section.

Approved by: mav

FreeBSD — stable/11/sys/dev/ocs_fc ocs_os.h ocs_os.c

MFC r332471, r332646:
   Check if STACK is defined before using the stack(9).
   Moved opts-stack.h include before all other includes.

Approved by: mav

FreeBSD — head/sys/kern kern_lockf.c

lockf: add per-chain locks to the owner hash

This combined with previous changes significantly depessimizes the behaviour
under contentnion.

In particular the lock1_processes test (locking/unlocking separate files)
from the will-it-scale suite was executed with 128 concurrency on a
4-socket Broadwell with 128 hardware threads.

Operations/second (lock+unlock) go from ~750000 to ~45000000 (6000%)
For reference single-process is ~1680000 (i.e. on stock kernel the resulting
perf is less than *half* of the single-threaded run),

Note this still does not really scale all that well as the locks were just
bolted on top of the current implementation. Significant room for improvement
is still here. In particular the top performance fluctuates depending on the
extent of false sharing in given run (which extends beyond the file).
Added chain+lock pairs were not padded w.r.t. cacheline size.

One big ticket item is the hash used for spreading threads: it used to be the
process pid (which basically serialized all threaded ops). Temporarily the
vnode addr was slapped in instead.

Tested by:      pho
Delta File
+27 -18 head/sys/kern/kern_lockf.c
+27 -18 1 file

FreeBSD — head/sys/kern kern_lockf.c

lockf: skip locking the graph if not necessary (common case)

Tested by:      pho
Delta File
+9 -6 head/sys/kern/kern_lockf.c
+9 -6 1 file

FreeBSD — head/sys/kern kern_lockf.c

lockf: perform wakeup onlly when there is anybody waiting

Tested by:      pho
Delta File
+2 -1 head/sys/kern/kern_lockf.c
+2 -1 1 file

FreeBSD — head/sys/kern kern_lockf.c

lockf: skip the hard work in lf_purgelocks if possible

Tested by:      pho
Delta File
+7 -0 head/sys/kern/kern_lockf.c
+7 -0 1 file

FreeBSD — head/sys/kern kern_lockf.c

lockf: free state only when recycling the vnode

This avoids malloc/free cycles when locking/unlocking the vnode when
nobody is contending.

Tested by:        pho
Delta File
+50 -71 head/sys/kern/kern_lockf.c
+50 -71 1 file

FreeBSD — head/usr.sbin/syslogd syslogd.c

Correct size for allocation and bzero of fdsr.

MFC after:        2 weeks
Delta File
+2 -2 head/usr.sbin/syslogd/syslogd.c
+2 -2 1 file

FreeBSD — head/usr.bin/grep file.c

bsdgrep: Fix build failure WITHOUT_LZMA (incorrect bracket placement)

Submitted by:        sbruno
Reported by:        sbruno
Delta File
+1 -1 head/usr.bin/grep/file.c
+1 -1 1 file

FreeBSD — head/usr.sbin/pwd_mkdb pwd_mkdb.8

pwd_mkdb: add deprecation notice in manpage too

Followon to r332789; as reported on the -current and -stable lists and
in review D15144 the -l option will be removed before FreeBSD 12.0.
Delta File
+6 -1 head/usr.sbin/pwd_mkdb/pwd_mkdb.8
+6 -1 1 file

FreeBSD — head/share/misc committers-src.dot

Update committers-src.dot to show the mentorship arrangement for myself: eadler has agreed 
to mentor me.

FreeBSD — head/share/misc committers-src.dot, head/usr.bin/calendar/calendars calendar.freebsd

Update account and given names in committers-src.dot and calendar.freebsd

I have changed my given name from Bruce to Rebecca, and my FreeBSD account
from brucec to bcran.
Update committers-src.dot and calendar.freebsd to show these changes.

Reviewed by:        rrs
Differential Revision: https://reviews.freebsd.org/D15125

FreeBSD — head/sys/kern vfs_bio.c

Make bufdaemon and bufspacedaemon use kthread_suspend_check instead of
kproc_suspend_check.  In r329612 bufspacedaemon was turned into a thread
of the bufdaemon process causing both to call kproc_suspend_check with the
same proc argument and that function contains the following while loop:

while (SIGISMEMBER(p->p_siglist, SIGSTOP)) {
        msleep(&p->p_siglist, &p->p_mtx, PPAUSE, "kpsusp", 0);

So one thread wakes up the other and the other wakes up the first again,
locking up UP machines on shutdown.

Also register the shutdown handlers with SHUTDOWN_PRI_LAST + 100 so they
run after the syncer has shutdown, because the syncer can cause a
situation where bufdaemon help is needed to proceed.

PR:                227404
Reviewed by:        kib
Tested by:        cy, rmacklem
Delta File
+7 -4 head/sys/kern/vfs_bio.c
+7 -4 1 file

FreeBSD — head/sys/kern kern_descrip.c kern_lockf.c

lockf: slightly depessimize

1. check if P_ADVLOCK is already set and if so, don't lock to set it
(stolen from DragonFly)
2. when trying for fast path unlock, check that we are doing unlock
first instead of taking the interlock for no reason (e.g. if we want
to *lock*). whilere make it more likely that falling fast path will
not take the interlock either by checking for state

Note the code is severely pessimized both single- and multithreaded.

FreeBSD — head/contrib/ofed/libibverbs init.c

Remove the "load drivers" logic from libibverbs.

The "load drivers" logic in the libibverbs configuration file is relevant
for Linux only.

MFC after:        3 days
Sponsored by:        Mellanox Technologies
Delta File
+0 -263 head/contrib/ofed/libibverbs/init.c
+0 -263 1 file

FreeBSD — head/sys/powerpc/include cpu.h, head/sys/powerpc/powerpc cpu.c

Fix the build post r332859

sysentvec::sv_hwcap/sv_hwcap2 are pointers to  u_long, so cpu_features* need
to be u_long to use the pointers.  This also requires a temporary cast in
printing the bitfields, which is fine because the feature flag fields are
only 32 bits anyway.

FreeBSD — head/cddl/usr.sbin/dwatch/libexec sendrecv

dwatch(1): Remove the line used to demonstrate `-dev' option

In recently added sendrecv profile, there was a line purposefully
added to introduce a compilation error in which `-dev' is used to
debug the entry. Removing the entry.

Sponsored by:        Smule, Inc.

FreeBSD — head/cddl/usr.sbin/dwatch/libexec sendrecv Makefile

dwatch(1): Add profile for send(2)/recv(2) syscalls

Sponsored by:        Smule, Inc.

FreeBSD — head/cddl/usr.sbin/dwatch dwatch

dwatch(1): Add `-dev' option to aid debugging of profiles

The options `-d' (debug), `-e' (exit after compile), and `-v' (verbose)
when combined in any order (though best remembered as `-dev') will run
the conflated script through dtrace(1), test for error conditions, and
show the line that dtrace(1) failed at (with context).

If no errors are found, the output is the same as `-e[v]'.

When writing a new profile for dwatch(1), you can quickly test to
make sure it compiles by running `dwatch -devX profile_name' where
profiles live in /usr/libexec/dwatch or /usr/local/libexec/dwatch
(the latter being where profiles installed via ports should go).

Sponsored by:        Smule, Inc.
Delta File
+63 -1 head/cddl/usr.sbin/dwatch/dwatch
+63 -1 1 file

FreeBSD — stable/11/etc/rc.d ddb

MFC r332773: Fix ddb rc script

r288291 added a call to limits(1), which isn't available before partitions
are mounted. This broke the ddb rc script, which does not provide its own

Alleviate the situation here by providing a start_cmd. We still have other
problems with diskless setups that need to be considered, but this is a

PR:                206291
Delta File
+6 -0 stable/11/etc/rc.d/ddb
+6 -0 1 file

FreeBSD — projects/pnfs-planb-server/sys/fs/nfsclient nfs_clrpcops.c

Fix nfsrpc_layoutreturn() and nfscl_dofflayoutio() for the Flexible File
Layout returns/recalls and I/O errors against the DS.

FreeBSD — projects/pnfs-planb-server/sys/fs/nfs nfs_var.h nfsclstate.h, projects/pnfs-planb-server/sys/fs/nfsclient nfs_clstate.c nfs_clport.c

Add NFSv4.1 client support for Flexible File Layout callbacks and the
generation of Ioerr stats for the LayoutReturn reply.
These changes are needed by the client to do testing of the mirrored
pNFS server configuration.

FreeBSD — head/sys/dev/bktr msp34xx.c

Remove unused definition bl_dfp; fix build with bktr compiled into kernel

PR:                216566
Submitted by:        mail at fbsd.e4m.org
Reviewed by:        riggs, cognet
Approved by:        cognet
MFC after:        3 days
Delta File
+0 -4 head/sys/dev/bktr/msp34xx.c
+0 -4 1 file

FreeBSD — head/sys/kern kern_shutdown.c

When running with INVARIANTS, the kernel contains extra checks.  However,
these assumptions may not hold true once we've panic'd. Therefore, the
checks hold less value after a panic.  Additionally, if one of the checks
fails while we are already panic'd, this creates a double-panic which can
interfere with debugging the original panic.

Therefore, this commit allows an administrator to suppress a response to
KASSERT checks after a panic by setting a tunable/sysctl.  The
tunable/sysctl (debug.kassert.suppress_in_panic) defaults to being

Reviewed by:        kib
Sponsored by:        Netflix, Inc.
Differential Revision:        https://reviews.freebsd.org/D12920
Delta File
+9 -0 head/sys/kern/kern_shutdown.c
+9 -0 1 file

FreeBSD — head/sys/powerpc/powerpc elf32_machdep.c elf64_machdep.c

Export powerpc CPU features for auxvec

FreeBSD exports the AT_HWCAP* auxvec items if provided by the ELF sysentvec
structure.  Add the CPU features to be exported, so user space can more
easily check for them without using the hw.cpu_features and hw.cpu_features2

FreeBSD — head/usr.bin/grep util.c

bsdgrep: Use grep_strdup instead of grep_malloc+strcpy
Delta File
+1 -2 head/usr.bin/grep/util.c
+1 -2 1 file

FreeBSD — head/etc/defaults rc.conf, head/etc/rc.d cfumass Makefile

Add cfumass rc script, to create a LUN for cfumass(4).

MFC after:        2 weeks
Relnotes:        yes
Sponsored by:        The FreeBSD Foundation
Differential Revision:        https://reviews.freebsd.org/D14844

FreeBSD — head/usr.bin/grep util.c

bsdgrep: Fix --include/--exclude ordering issues

Prior to r332851:
* --exclude always win out over --include
* --exclude-dir always wins out over --include-dir

r332851 broke that behavior, resulting in:
* First of --exclude, --include wins
* First of --exclude-dir, --include-dir wins

As it turns out, both behaviors are wrong by modern grep standards- the
latest rule wins. e.g.:

`grep --exclude foo --include foo 'thing' foo`
foo is included

`grep --include foo --exclude foo 'thing' foo`
foo is excluded

As tested with GNU grep 3.1.

This commit makes bsdgrep follow this behavior.

Reported by:        se
Delta File
+10 -4 head/usr.bin/grep/util.c
+10 -4 1 file

FreeBSD — stable/11/usr.bin/clang/clang clang.1

MFC r332414:

Regenerate clang man page after upstream change to document the possible
values for the -std= option.

Noticed by:        Steve Kargl
Obtained from:        https://reviews.llvm.org/rL329827
Delta File
+258 -3 stable/11/usr.bin/clang/clang/clang.1
+258 -3 1 file

FreeBSD — head/sys/powerpc/include cpu.h, head/sys/powerpc/powerpc cpu.c

Sync powerpc feature flags with Linux

Not all feature flags are synced.  Those for processors we don't currently
support are ignored currently.  Those that are supported are synced best I
can tell.  One flag was renamed to match the Linux flag name

FreeBSD — head/sys/conf files, head/sys/modules/blake2 Makefile

blake2: Disable warnings (not just error) for code we will not modify

Leave libb2 pristine and silence the warnings for mjg.

FreeBSD — head/usr.bin/grep file.c

bsdgrep: if chain => switch

This makes some of this a little easier to follow (in my opinion).
Delta File
+70 -49 head/usr.bin/grep/file.c
+70 -49 1 file

FreeBSD — head/usr.bin/grep util.c

bsdgrep: More trivial cleanup/style cleanup

We can avoid branching for these easily reduced patterns
Delta File
+5 -14 head/usr.bin/grep/util.c
+5 -14 1 file

FreeBSD — head/usr.bin/grep util.c

bsdgrep: Some light cleanup

There's no point checking for a bunch of file modes if we're not a
practicing believer of DIR_SKIP or DEV_SKIP.

This also reduces some style violations that were particularly ugly looking
when browsing through.
Delta File
+5 -5 head/usr.bin/grep/util.c
+5 -5 1 file

FreeBSD — head/contrib/llvm/tools/lldb/source/Plugins/Process/FreeBSD ProcessMonitor.cpp

lldb: propagate error to user if memory read fails

Previously, an attempt to read an unreadable access reported zeros:

(lldb) memory read -format hex -size 8 0
0x00000000: 0x0000000000000000 0x0000000000000000
0x00000010: 0x0000000000000000 0x0000000000000000

Now, if DoReadMemory encounters error then return 0 (bytes read) so we
report the error to the user:

(lldb) memory read -format hex -size 8 0
error: Bad address

LLVM PR:        37190

MFC after:        1 week
Sponsored by:        The FreeBSD Foundation

FreeBSD — stable/11/tools/tools README

MFC r332673: Remove mention of tools/recoverdisk, now in sbin

PR:                227570
Delta File
+0 -1 stable/11/tools/tools/README
+0 -1 1 file

FreeBSD — projects/pnfs-planb-server/usr.bin pnfsdskill, projects/pnfs-planb-server/usr.bin/pnfsdskill pnfsdskill.c pnfsdskill.1

Add the pnfsdskill command that can be used on the MDS to disable a mirrored

FreeBSD — projects/pnfs-planb-server/usr.bin pnfsdscopymr, projects/pnfs-planb-server/usr.bin/pnfsdscopymr pnfsdscopymr.c pnfsdscopymr.1

Add the pnfsdscopymr command that is used to copy a file to a recovered
mirrored DS.

FreeBSD — projects/pnfs-planb-server/usr.bin/pnfsdsfile pnfsdsfile.c pnfsdsfile.1

Add the "-r" option to be used for mirrored DS recovery, plus a few small fixes.

FreeBSD — head/usr.sbin/makefs Makefile, head/usr.sbin/makefs/cd9660 Makefile.inc

makefs: tidy up reach-over source

- cd9660 relies on an #include "iso.h" but does not build any .c files
  out of source, so remove reach-over .PATH
- ffs does not rely on any sys/ headers, so remove -I from CFLAGS.
- ffs_tables from sys/ is used by ffs; move the SRCS entry from the top-
  level Makefile to ffs' Makefile.inc.

Sponsored by:        The FreeBSD Foundation

FreeBSD — head/sys/dev/extres/regulator regulator.c

regulator: Check status before disabling

When disabling regulator when they are unused, check before is they are
While here don't check the enable_cnt on the regulator entry as it is
checked by regnode_stop.
This solve the panic on any board using a fixed regulator that is driven
by a gpio when the regulator is unused.

Tested On: OrangePi One
Pointy Hat to:            myself
Reported by:        kevans, Milan Obuch (freebsd-arm at dino.sk)

FreeBSD — stable/11/sys/netinet6 ip6_output.c

MFC r319216:
  Fix an unnecessary/incorrect check in the PKTOPT_EXTHDRCPY macro.

  This macro allocates memory and, if malloc does not return NULL, copies
  data into the new memory. However, it doesn't just check whether malloc
  returns NULL. It also checks whether we called malloc with M_NOWAIT. That
  is not necessary.

  While it may be that malloc() will only return NULL when the M_NOWAIT flag
  is set, we don't need to check for this when checking malloc's return
  value. Further, in this case, the check was not completely accurate,
  because it checked for flags == M_NOWAIT, rather than treating it as a bit
  field and checking for (flags & M_NOWAIT).

Sponsored by:        Netflix, Inc.

FreeBSD — stable/11/sys/netinet6 icmp6.c

MFC r319215:
  Fix two places in the ICMP6 code where we could dereference a NULL pointer
  in the icmp6_input() function.

  When processing an ICMP6_ECHO_REQUEST, if IP6_EXTHDR_GET fails, it will
  set nicmp6 and n to NULL. Therefore, we should condition our modification
  to nicmp6 on n being not NULL.

  And, when processing an ICMP6_WRUREQUEST in the (mode != FQDN) case, if
  m_dup_pkthdr() fails, the code will set n to NULL. However, the very next
  line dereferences n. Therefore, when m_dup_pkthdr() fails, we should
  discontinue further processing and follow the same path as when m_gethdr()

Reported by:        clang static analyzer
Sponsored by:        Netflix, Inc.
Delta File
+3 -2 stable/11/sys/netinet6/icmp6.c
+3 -2 1 file

FreeBSD — stable/11/sys/netinet ip_icmp.c, stable/11/sys/netinet6 udp6_usrreq.c

MFC r319214:
  Enforce the limit on ICMP messages before doing work to formulate the

  Delete an unneeded rate limit for UDP under IPv6. Because ICMP6
  messages have their own rate limit, it is unnecessary to apply a
  second rate limit to UDP messages.

Sponsored by:        Netflix, Inc.

FreeBSD — head/sys/gnu/dts/arm omap44xx-clocks.dtsi dra7xx-clocks.dtsi, head/sys/gnu/dts/include/dt-bindings bus

gnu/dts: Update our copy of arm dts from Linux 4.16