OPNSense/core 0db5c3bsrc/opnsense/mvc/app/controllers/OPNsense/Proxy/forms dialogEditPACRule.xml, src/opnsense/mvc/app/models/OPNsense/Proxy Proxy.xml

www/squid: add proxy sortable support for proxy lists

OPNSense/core 68c574asrc/etc/inc gwlb.inc

gwlb.inc, an empty gateway group can cause "Warning: count(): Parameter must be an array 
or an object that implements Countable in /usr/local/etc/inc/gwlb.inc on line 757"

(cherry picked from commit a66852b433a4743676f2dc22f508c55b1f61d27f)

OPNSense/core ec1802bsrc/etc/inc interfaces.inc

interfaces: allow interfaces_addresses() to emit subnets #3355

(cherry picked from commit 986b2ad6d9ce88055b594a4b8a918378e236794b)
(cherry picked from commit ad8ee2f286cb136f3ea186929b4323a76d9f528f)

OPNSense/core 31a81c5src/etc/inc/plugins.inc.d unbound.inc

unbound: add OpenVPN to ACL by default; closes #3342

OPNSense/core 0e95b0f. LICENSE plist, src/etc rc.kill_states

interfaces: remove rc.kill_states

There's no real world evidence this works or is needed today.
We do have to other state kills / flushes now, one works and
the other may be defunct.  To progress this remove this arcane
script and if the need arises rewrite it as something portable.

See:      https://redmine.pfsense.org/issues/1629
Also see: https://redmine.pfsense.org/issues/2887

OPNSense/core b395ec0src/etc/inc interfaces.inc filter.lib.inc, src/etc/inc/xmlrpc legacy.inc

inc: whoops, different way of returning subnets #3355

OPNSense/core fe99a9bsrc/etc/inc xmlrpc.inc

xmlrpc: style sweep
DeltaFile
+22-24src/etc/inc/xmlrpc.inc
+22-241 files

OPNSense/core 39acde6src/etc/inc interfaces.lib.inc

interfaces: remove legacy_getall_interface_addresses(); closes #3355

OPNSense/core 9105280src/etc/inc filter.lib.inc interfaces.inc, src/etc/inc/xmlrpc legacy.inc

interfaces: remove remaining legacy_getall_interface_addresses() #3355

OPNSense/core 48e4fdesrc/etc/inc/plugins.inc.d unbound.inc

unbound: replace legacy_getall_interface_addresses() #3355

While here use a cheaper single lookup for all interfaces at once.

OPNSense/core ad8ee2fsrc/etc/inc interfaces.inc

interfaces: clear scope when emitting subnets #3355

OPNSense/core 986b2adsrc/etc/inc interfaces.inc

interfaces: allow interfaces_addresses() to emit subnets #3355

OPNSense/core 193c0e9src/opnsense/mvc/app/views/OPNsense/Cron index.volt

system: remove stray empty line in cron volt

OPNSense/core 9e5d334src/etc/inc config.inc, src/opnsense/mvc/app/library/OPNsense/Core Config.php

Cleanup backups after saving in MVC

(cherry picked from commit 26f3d71662de4ec0b105bfa1d8ec6635000aa3f6)
(cherry picked from commit cfbaafb8d592c9ae0a1b6aeba7326733e679c0d1)

OPNSense/core 4a937e9src/www vpn_ipsec_phase1.php

IPsec, bug in https://github.com/opnsense/core/issues/2332  "installpolicy" should be set 
by default

(cherry picked from commit 8b8bbc3bc73c78b536a7bd3e83dcf22e490c1678)

OPNSense/core dc0f439src/opnsense/mvc/app/views/OPNsense/CaptivePortal index.volt

Captive portal, show message on save (settings need apply)

OPNSense/core 13fa8b9src/opnsense/mvc/app/views/OPNsense/IDS index.volt

IDS, show message on save (settings need apply)

OPNSense/core 1c5c40bsrc/opnsense/mvc/app/views/OPNsense/Firewall alias.volt

Firewall/aliases, show message on save (settings need apply)

OPNSense/core 8b8bbc3src/www vpn_ipsec_phase1.php

IPsec, bug in https://github.com/opnsense/core/issues/2332  "installpolicy" should be set 
by default

OPNSense/core ee17fa6src/opnsense/mvc/app/views/OPNsense/TrafficShaper index.volt

Shaper, show message on save (settings need apply)

OPNSense/core 9b430c3src/opnsense/mvc/app/views/OPNsense/Proxy index.volt

Proxy, simplify save message handling in remote ACL

OPNSense/core 3e386e8src/opnsense/mvc/app/views/OPNsense/Routes index.volt

Routes, show message on save (settings need apply)

OPNSense/core 63b32basrc/opnsense/mvc/app/views/OPNsense/Cron index.volt

Cron, simplify save message handling

OPNSense/core 3bfb8c8src/opnsense/www/js opnsense_bootgrid_plugin.js

opnsense_bootgrid_plugin.js welcome data-editAlert tag

OPNSense/core e87cee8src/etc/inc config.inc, src/opnsense/mvc/app/library/OPNsense/Core Config.php

Merge branch 'Sergey-Kirpa-cleanup-backups-after-saving'

OPNSense/core cfbaafbsrc/opnsense/mvc/app/library/OPNsense/Core Config.php

config, remove old backups after save. https://github.com/opnsense/core/pull/3352 although 
the idea is good, the code quality really needs attention.

OPNSense/core 26f3d71src/etc/inc config.inc, src/opnsense/mvc/app/library/OPNsense/Core Config.php

Cleanup backups after saving in MVC

Refactoring: Move legacy function cleanup_backups() to
OPNsense/Core/Config::cleanupBackups()

OPNSense/core af55c85src/www firewall_rule_lookup.php

filter, rule statistics, close window when not found (firewall_rule_lookup.php), for 
https://github.com/opnsense/core/issues/3312

OPNSense/core 13f8a64src/etc/inc interfaces.inc gwlb.inc, src/opnsense/mvc/app/library/OPNsense/Auth AuthenticationFactory.php

Fix it's, repeated words and a/an (#3332)


(cherry picked from commit 3f673e3ce67bbfcb420155b84fda911410773551)

OPNSense/core abcf334src/etc/inc filter.lib.inc

filter, better describe force gateway rule. related  to 
https://github.com/opnsense/core/issues/3312

OPNSense/core 3f673e3src/etc/inc interfaces.inc services.inc, src/opnsense/mvc/app/models/OPNsense/Base BaseModel.php

Fix it's, repeated words and a/an (#3332)

OPNSense/core 114b904src/www firewall_rules.php

filter, remove static blocks from overview grid, optionally expand to all auto-generated 
rules. closes https://github.com/opnsense/core/issues/3312

- remove "Block all IPv6 traffic" block
- remove "Anti-Lockout Rule" block
- remove "Block private networks" block
- remove "Block bogon networks" block
- add all plugged-in filter rules for the selected interface
DeltaFile
+73-100src/www/firewall_rules.php
+73-1001 files

OPNSense/core a0b5942src/opnsense/mvc/app/library/OPNsense/Firewall Rule.php

filter, add some getters for https://github.com/opnsense/core/issues/3312

OPNSense/core 4c0f9a7src/opnsense/mvc/app/library/OPNsense/Firewall Plugin.php

Filter, always generate hash if label isn't provided. for 
https://github.com/opnsense/core/issues/3312

OPNSense/core a66852bsrc/etc/inc gwlb.inc

gwlb.inc, an empty gateway group can cause "Warning: count(): Parameter must be an array 
or an object that implements Countable in /usr/local/etc/inc/gwlb.inc on line 757"

OPNSense/core 31b4479src/www firewall_rules.php

Firrewall, rules. move some presentation logic into its own functions, to ease 
presentation of equal logic for https://github.com/opnsense/core/issues/3312
DeltaFile
+116-85src/www/firewall_rules.php
+116-851 files

OPNSense/core 198887esrc/etc/inc/plugins.inc.d ipsec.inc

IPsec, route-based, don't add reqid when not using route-based, although it should 
funciton without issues, people seem to report problems with it.

(cherry picked from commit 15b9be0369e390a8276946fa5dae1ac8fae4f85a)

OPNSense/core 15b9be0src/etc/inc/plugins.inc.d ipsec.inc

IPsec, route-based, don't add reqid when not using route-based, although it should 
funciton without issues, people seem to report problems with it.

OPNSense/core 07389bdsrc/etc/inc/plugins.inc.d openvpn.inc

openvpn: try to "solve" get_failover_interface() issues

(cherry picked from commit 96683647f52ddfc011c52d8e165c9ee6c97963c5)
(cherry picked from commit 6a4fa40e72474dfb88636ce8acf154ae84d10ae3)

OPNSense/core 77b2416src/etc/inc/plugins.inc.d/openvpn auth-user.php

OpenVPN server, support static-challenge formatted password, closes 
https://github.com/opnsense/core/issues/3290

(cherry picked from commit 2c2eca7e2f25a46f96458e0d6d924541574cb9d8)

OPNSense/core 6da7b31src/opnsense/mvc/app/controllers/OPNsense/TrafficShaper/forms dialogRule.xml dialogPipe.xml

TrafficShaper, capitalize dialog labels

(cherry picked from commit b9f04f24d0d4bf79a25fa4de22f609971196901d)

OPNSense/core b9f04f2src/opnsense/mvc/app/controllers/OPNsense/TrafficShaper/forms dialogRule.xml dialogPipe.xml

TrafficShaper, capitalize dialog labels

OPNSense/core 53bc9f4src/opnsense/mvc/app/views/OPNsense/Firewall alias.volt

Firewall -> Aliases, remember grid settings

OPNSense/core 10bd299src/opnsense/mvc/app/views/OPNsense/Firewall alias_util.volt

Firewall -> Diagnostics -> pfTables, remember previous settings in grid

OPNSense/core 7367a3bsrc/opnsense/www/js opnsense_bootgrid_plugin.js

MVC, bootgrid, opt-in to remember previous selected columns and rowcount when 
data-store-selection="true"

OPNSense/core 2a9bc8fsrc/opnsense/mvc/app/models/OPNsense/Proxy Proxy.xml

Added check on SNI field checkbox (#3338)

OPNSense/core f8143ef. Makefile

pkg: switch to PHP 7.2

For older package sets use:

    # make upgrade CORE_PHP=71

Discussed with: @adschellevis
DeltaFile
+1-1Makefile
+1-11 files

OPNSense/core b5cfb6b. plist, src/opnsense/mvc/app/controllers/OPNsense/Firewall AliasController.php

firewall: remove unused alias edit dialog

OPNSense/core ee98c7bsrc/opnsense/mvc/app/views/OPNsense/Firewall alias.volt

firewall: uppercase translation

OPNSense/core bc29f37src/opnsense/mvc/app/controllers/OPNsense/Firewall AliasController.php

firewall: reformat header