OPNSense/core c6c3252src/etc/rc.subr.d var

rc: permanent location for patches

OPNSense/core 98bef78src/opnsense/mvc/app/models/OPNsense/Core/Menu Menu.xml, src/opnsense/mvc/app/models/OPNsense/Diagnostics/Menu Menu.xml

routing: add a separate static menu

PR: https://github.com/opnsense/core/pull/2878

OPNSense/core be010a1src/opnsense/mvc/app/models/OPNsense/Core/Menu Menu.xml, src/opnsense/mvc/app/models/OPNsense/Diagnostics/Menu Menu.xml

routing: add a separate static menu

PR: https://github.com/opnsense/core/pull/1647

OPNSense/core 4adc8edsrc/opnsense/mvc/app/controllers/OPNsense/Core/Api FirmwareController.php, src/opnsense/scripts/firmware check.sh

firmware: connection is ok, repository is not

Just change the returned information into something that
makes sense here.  No functional changes between both
sides except we check repository for != 'ok' so we catch
all types of errors if they are added in the future.  Same
is already true for connection.

OPNSense/core 084fdeasrc/opnsense/mvc/app/models/OPNsense/IDS/Migrations M1_0_2.php

IDS, migration to 1.0.2, fix Trying to get property of non-object in....

(cherry picked from commit c28b7915eee1a48aae18b3f90f1734efaa3e9b72)

OPNSense/core c28b791src/opnsense/mvc/app/models/OPNsense/IDS/Migrations M1_0_2.php

IDS, migration to 1.0.2, fix Trying to get property of non-object in....

OPNSense/core e9edf02src/opnsense/scripts/firmware health.sh

firmware: correct invisible error in health check

(cherry picked from commit efbe2d5e9848f52bd42d2fb6c2753471a04eee20)

OPNSense/core f284230src/opnsense/mvc/app/models/OPNsense/Monit Monit.php, src/opnsense/mvc/app/views/OPNsense/Monit index.volt

Monit, regression in refactor

(cherry picked from commit a2899594a0f2837f248f852c65f2c27bfbae7f32)

OPNSense/core 3b704a5src/etc/inc console.inc

console: this is not entirely correct

(cherry picked from commit 9f935b533f834c254ce239a5ea100734e872a4a3)

OPNSense/core 9f935b5src/etc/inc console.inc

console: this is not entirely correct

OPNSense/core a289959src/opnsense/mvc/app/models/OPNsense/Monit Monit.php, src/opnsense/mvc/app/views/OPNsense/Monit index.volt

Monit, regression in refactor

OPNSense/core efbe2d5src/opnsense/scripts/firmware health.sh

firmware: correct invisible error in health check

OPNSense/core 24e452asrc/etc/inc/plugins.inc.d unbound.inc

unbound: prefer-ip6 is defaulting to 'no' for unbound

which makes this precaution a complication as unbound disables
IPv6 responses with it as well and we shouldn't set prefer-ip6
to 'yes' to avoid further breakage.

PR: https://forum.opnsense.org/index.php?topic=10810.0
(cherry picked from commit 53024b5c159c7c47603645baf08d4b34d4af43f7)

OPNSense/core 23c7c6fsrc/opnsense/mvc/app/models/OPNsense/Monit Monit.php

monit: style sweep

OPNSense/core 0627451src/opnsense/mvc/app/controllers/OPNsense/Monit/Api SettingsController.php, src/opnsense/mvc/app/controllers/OPNsense/Monit/forms services.xml

Monit, major cleanup, related to https://github.com/opnsense/core/pull/3119

(cherry picked from commit df8d12c8a0e8abb4d3d180f56cc6129b237cb505)
(cherry picked from commit 6d11ffc2ab374b7f0db19cf6f1bf8aba495ddd8f)
(cherry picked from commit c32cb08f58f57b6d7a36049c3a3608f3b701c540)

OPNSense/core c32cb08. LICENSE, src/opnsense/mvc/app/views/OPNsense/Monit index.volt status.volt

monit: correct copyright headers, update LICENSE

OPNSense/core 4ae8b31src/opnsense/mvc/app/controllers/OPNsense/Monit/Api SettingsController.php, src/opnsense/mvc/app/controllers/OPNsense/Monit/forms tests.xml

monit: add Service/Test type relation; improve Service Tests UI

(cherry picked from commit 29abe8e16ec4c9660b457b30646f28d0324c7a67)
(cherry picked from commit 4f88d926e5e5448db00786279305c0e2b962feeb)
(cherry picked from commit cfca9304663ac57c8362afe8422b6ad06a23c327)

OPNSense/core 8bc62c1src/www vpn_openvpn_client.php

openvpn: flip back to multiple

It looked like the original request was misunderstood and this
changed the wrong option.

PR: https://forum.opnsense.org/index.php?topic=10950.0
(cherry picked from commit 1c8731dd784cf5bd101f8d433f99d9f6a68a982c)

OPNSense/core 1e092desrc/opnsense/mvc/app/models/OPNsense/Base BaseModel.php

MVC, treat an empty ArrayField as non existent, closes 
https://github.com/opnsense/core/issues/3123

(cherry picked from commit a111b345ffe29410844aeb95f2979237bb3094f0)

OPNSense/core c2ec702src/opnsense/mvc/app/models/OPNsense/Base BaseModel.php

MVC, treat an empty ArrayField as non existent, closes 
https://github.com/opnsense/core/issues/3123

(cherry picked from commit a111b345ffe29410844aeb95f2979237bb3094f0)

OPNSense/core a111b34src/opnsense/mvc/app/models/OPNsense/Base BaseModel.php

MVC, treat an empty ArrayField as non existent, closes 
https://github.com/opnsense/core/issues/3123

OPNSense/core 6d11ffcsrc/opnsense/mvc/app/controllers/OPNsense/Monit/Api SettingsController.php, src/opnsense/mvc/app/views/OPNsense/Monit index.volt

Monit, notifications are depricated in 19.1, remove the import here.

OPNSense/core 8c54709src/opnsense/mvc/app/controllers/OPNsense/Monit/Api SettingsController.php, src/opnsense/mvc/app/controllers/OPNsense/Monit/forms services.xml

Merge branch 'fbrendel-monit'

OPNSense/core df8d12csrc/opnsense/mvc/app/controllers/OPNsense/Monit/Api SettingsController.php, src/opnsense/mvc/app/controllers/OPNsense/Monit/forms services.xml alerts.xml

Monit, major cleanup, related to https://github.com/opnsense/core/pull/3119

- remove locking in model, core framework should do that if required. (see Config->lock), 
deadlock issues in previous code (freezing UI)
- in settings controller, expand endpoints to one per type (in stead of "one to rule them 
all")
- in settings controller, align to base wrappers of ApiMutableModelControllerBase
- move extended validations to model, to avoid validation issues when another service 
would like to reuse the model
- align forms to standard wrappers (naming convention, simplifies code)
- remove "deleteRelations", if we need something like this at some point, it should be in 
the model, for now it seems safe enough to ditch
- ditch migration code, since it does the same as having a default value (defaults are 
always enforced during migrations)
** left UnitTest code for what it is now, probably needs changes too

OPNSense/core e4b194esrc/opnsense/mvc/app/controllers/OPNsense/Core/Api FirmwareController.php, src/opnsense/scripts/firmware check.sh

firmware: also detect a revoked fingerprint

OPNSense/core 8d0fc74src/opnsense/mvc/app/controllers/OPNsense/Monit/forms services.xml, src/opnsense/mvc/app/models/OPNsense/Monit Monit.xml

monit: Support declaring dependencies

(cherry picked from commit 105462bb5d17468daabe0470a16eaac585b01b78)
(cherry picked from commit 8ad3b9d1a2437a9619524f6d3cb28694672ebc58)

OPNSense/core 5fdadcfsrc/opnsense/mvc/script load_phalcon.php

Fix usage of include_once in load_phalcon.php (#3109)

include_once returns TRUE if the file has already been loaded. This is not what you want 
if you're setting a variable from it.
http://php.net/manual/en/function.include-once.php

This fixes notices when including certain old scripts from modern controllers, as well as 
a notice when running run_migrations.php.

(cherry picked from commit e3de6b2e28d24b9b113c1ee95a40b990ef8374ec)

OPNSense/core 70c2e0esrc/opnsense/mvc/app/controllers/OPNsense/Monit/Api SettingsController.php, src/opnsense/mvc/app/controllers/OPNsense/Monit/forms tests.xml

Merge branch 'monit' of https://github.com/fbrendel/core into fbrendel-monit

OPNSense/core e3de6b2src/opnsense/mvc/script load_phalcon.php

Fix usage of include_once in load_phalcon.php (#3109)

include_once returns TRUE if the file has already been loaded. This is not what you want 
if you're setting a variable from it.
http://php.net/manual/en/function.include-once.php

This fixes notices when including certain old scripts from modern controllers, as well as 
a notice when running run_migrations.php.

OPNSense/core f201d02src/etc/inc/plugins.inc.d ipsec.inc

missed a spot in previous

OPNSense/core ac99876src/etc/inc/plugins.inc.d ipsec.inc

IPsec, add interface when phase1 is enabled, simplify logic. (from irc)

OPNSense/core 7d7e7f0src/opnsense/scripts/filter/lib geoip.py

Firewall/Alias, geoip, switch download to https

(cherry picked from commit 53a5ea0ca7e4e00d1a4c7a9ed29e8a9b36884151)

OPNSense/core 53a5ea0src/opnsense/scripts/filter/lib geoip.py

Firewall/Alias, geoip, switch download to https

OPNSense/core e6170c1src/opnsense/mvc/app/controllers/OPNsense/Monit/forms services.xml, src/opnsense/mvc/app/models/OPNsense/Monit Monit.xml

Merge branch 'awerner-monit_deps'

OPNSense/core 8ad3b9dsrc/opnsense/mvc/app/controllers/OPNsense/Monit/forms services.xml

Monit, clarify help message a bit. for https://github.com/opnsense/core/pull/3001

OPNSense/core dbb22bbsrc/opnsense/mvc/app/controllers/OPNsense/Monit/forms services.xml, src/opnsense/mvc/app/models/OPNsense/Monit Monit.xml

Merge branch 'monit_deps' of https://github.com/awerner/core into awerner-monit_deps

OPNSense/core f3dad94src/opnsense/mvc/app/library/OPNsense/Firewall Util.php, src/opnsense/service/templates/OPNsense/Filter filter_tables.conf

Add support IDN in aliases. (#3107)

OPNSense/core 5ad2c28src/etc/ssl opnsense.cnf, src/www system_certmanager.php

Add option to create combined client and server certificate, closes #2800 (#3130)

(cherry picked from commit ea8dce33ba8db5b71683bd582ac42f1b103801d4)
(cherry picked from commit d8579502b71be44b4bc0ac0ca7144cbecf6ae2d3)

OPNSense/core 587a28esrc/opnsense/service/conf/actions.d actions_system.conf actions_firmware.conf

system: move "reboot" cron hook to better location

Firmware has both reboot and poweroff (halt) for early API access reasons,
but since they are not in the best place start by migrating the cron hook.

I am not sure when we should remove the firmware hooks, maybe in 19.7...

(cherry picked from commit 5a1b1d50f0910919694ddbd25d49208462b857c2)

OPNSense/core 42ddba7src/opnsense/mvc/app/controllers/OPNsense/Core RebootController.php, src/opnsense/mvc/app/controllers/OPNsense/Core/Api SystemController.php

Port reboot and shutdown pages to MVC (#3133)


(cherry picked from commit 5689dc8048cfe739f88619291190d029a59ed4b3)

OPNSense/core be2b26esrc/www system_general.php

system: hide gateway group selection for now

OPNSense/core 5a1b1d5src/opnsense/service/conf/actions.d actions_system.conf actions_firmware.conf

system: move "reboot" cron hook to better location

Firmware has both reboot and poweroff (halt) for early API access reasons,
but since they are not in the best place start by migrating the cron hook.

I am not sure when we should remove the firmware hooks, maybe in 19.7...

OPNSense/core 5689dc8src/opnsense/mvc/app/controllers/OPNsense/Core RebootController.php, src/opnsense/mvc/app/controllers/OPNsense/Core/Api SystemController.php

Port reboot and shutdown pages to MVC (#3133)

OPNSense/core 5d39ddasrc/opnsense/mvc/app/controllers/OPNsense/Core/Api FirmwareController.php, src/opnsense/scripts/firmware check.sh

firmware: show untrusted error instead of "no updates"

(cherry picked from commit fb3fd528ad9002a4627c0f0d0512f96220c991a6)

OPNSense/core cd45df6src/opnsense/mvc/app/models/OPNsense/Base/Constraints ComparedToFieldConstraint.php, src/opnsense/mvc/app/models/OPNsense/IDS/Migrations M1_0_2.php

src: header style updates, license additions, sync LICENSE

(cherry picked from commit 530c5220dca282d1f19fa235292b3f5afe9139ac)

OPNSense/core f5f5a66src/opnsense/mvc/app/controllers/OPNsense/Base ApiMutableServiceControllerBase.php, src/opnsense/mvc/app/controllers/OPNsense/IDS/Api ServiceController.php

src: style sweep, someone is feeling picky today

(cherry picked from commit 23f440ceee18d5878b1b967ecc63bd522fffff9c)

OPNSense/core 57a3c3esrc/opnsense/scripts/netflow/lib parse.py, src/opnsense/scripts/suricata __init__.py

src: fix lint-exec pass

(cherry picked from commit 86c7f6242c3e49cd2b45ba8bf4a124c69a332d77)

OPNSense/core f68cc74. Makefile

make: finish lint-exec excluding all arbitrary data

(cherry picked from commit f6a0443aa4c2c580d0e563278a1029b414aab0cf)
DeltaFile
+5-2Makefile
+5-21 files

OPNSense/core 0ac7e3f. Makefile

pkg: this is opnsense now, not opnsense-devel
DeltaFile
+3-3Makefile
+3-31 files

OPNSense/core fb3fd52src/opnsense/mvc/app/controllers/OPNsense/Core/Api FirmwareController.php, src/opnsense/scripts/firmware check.sh

firmware: show untrusted error instead of "no updates"