OPNSense/core 130436c. Makefile, src/root/boot logo-hourglass.4th

firmware: this is what 20.1 will be now

OPNSense/core 8d2a2cesrc/etc/inc interfaces.lib.inc

style fix, while working on https://github.com/opnsense/core/issues/3567, noticed a naming 
issue in legacy_interfaces_details()

(cherry picked from commit 67ba6bf12f0586469fad534eee9cd68d500a5c58)

OPNSense/core e045082src/etc/inc filter.inc

firewall: change verbose print start location

OPNSense/core 2115c0bsrc/etc/inc config.inc

system: add get_cached_json_content()

OPNSense/core f961061src/etc/inc config.inc

system: style fix

OPNSense/core 9e39578src/opnsense/mvc/app/models/OPNsense/Core ACL.php

src: style sweep

(cherry picked from commit fb9e8a563e3c392887235467a3282f3531a451b9)

OPNSense/core fb9e8a5src/etc/inc auth.inc config.inc, src/opnsense/mvc/app/models/OPNsense/Core ACL.php

src: style sweep

OPNSense/core 688e981src/opnsense/www/themes/opnsense/assets/stylesheets main.scss, src/opnsense/www/themes/opnsense/build/css main.css

wizard: minor style fix, better logo contrast in index.php?wizard_done= (new logo on white 
background )

(cherry picked from commit a373d411f67cb18711101aaf65299e814a75a61e)

OPNSense/core a373d41src/opnsense/www/themes/opnsense/assets/stylesheets main.scss, src/opnsense/www/themes/opnsense/build/css main.css

wizard: minor style fix, better logo contrast in index.php?wizard_done= (new logo on white 
background )

OPNSense/core d1ceb75src/www system_gateways_edit.php

System:gateways, only show enabled interfaces on edit. (prevents disappearing interfaces 
in overview)

(cherry picked from commit e42f8ba01cf16f2bc17717b21052f2938c2cff3c)

OPNSense/core 3ef84easrc/opnsense/mvc/app/library/OPNsense/Routing Gateways.php

System: gateways, make tunnel type interfaces less attractive for gateway selection by 
default

(cherry picked from commit a9786a6be03620ea235ddf0ad36eb3cf71b00fec)
(cherry picked from commit 62f1bb21f7fa358ee4ccf30f13cabca1060faca1)

OPNSense/core 3ff6c60. Makefile plist, src/opnsense firmware-message firmware-upgrade

firmware: track for 20.1 development now

OPNSense/core d2b8733src/www vpn_ipsec_phase2.php

IPsec:phase2, ip type selector using the wrong class, presenting wrong options in remote 
subnet (/128 vs /32). minor cleanup

(cherry picked from commit c3ccc63fd184168e22822fe49aabf7e7e8b40d1a)

OPNSense/core e73da48. Makefile, src/root/boot logo-hourglass.4th

firmware: a name for 19.7

OPNSense/core c3ccc63src/www vpn_ipsec_phase2.php

IPsec:phase2, ip type selector using the wrong class, presenting wrong options in remote 
subnet (/128 vs /32). minor cleanup

OPNSense/core 1da0794src/etc/inc/plugins.inc.d unbound.inc dpinger.inc

interfaces, pass ifconfig details in dpinger+unbound, for 
https://github.com/opnsense/core/issues/3567

OPNSense/core aa25ecfsrc/etc/inc interfaces.inc, src/etc/inc/plugins.inc.d dhcpd.inc

interfaces, performance. allow passing ifconfig details in get_interface_ip[v6] for 
https://github.com/opnsense/core/issues/3567

OPNSense/core 45b3d22src/etc/inc interfaces.inc interfaces.lib.inc

interfaces: performance  support passing ifconfig details to 
legacy_get_interface_addresses() and callers for 
https://github.com/opnsense/core/issues/3567

OPNSense/core c72e682src/etc/inc/plugins.inc.d dhcpd.inc

dhcpdv4: performance improvements, only call interfaces_staticarp_configure() when 
staticarp is used on this interface, prevent excessive legacy_interfaces_details() calls 
for https://github.com/opnsense/core/issues/3567

OPNSense/core 62f1bb2src/opnsense/mvc/app/library/OPNsense/Routing Gateways.php

typo in previous

OPNSense/core a9786a6src/opnsense/mvc/app/library/OPNsense/Routing Gateways.php

System: gateways, make tunnel type interfaces less attractive for gateway selection by 
default

OPNSense/core e42f8basrc/www system_gateways_edit.php

System:gateways, only show enabled interfaces on edit. (prevents disappearing interfaces 
in overview)

OPNSense/core 2e6b138src/etc/inc interfaces.inc

interfaces: interfaces_staticarp_configure(), don't flush arp table when booting, arp is 
really slow with a lot of interfaces. for https://github.com/opnsense/core/issues/3567

OPNSense/core 028e7a2src/etc/inc interfaces.inc

interfaces, cleanup. while working on https://github.com/opnsense/core/issues/3567

Since $realhwif is the parent interface, it doesn't make sense to check for _vlan. We 
might as well remove the check and leave the rest as is, since it only triggers when 
either media or mediaopt is set.

OPNSense/core 0a73a6fsrc/etc/inc filter.lib.inc

filter, pass ifconfig details in filter_core_rules_system() to improve loading. for 
https://github.com/opnsense/core/issues/3567

OPNSense/core 197e70dsrc/etc/inc interfaces.inc

interfaces, performance. support passing the output of our ifconfig parser for 
https://github.com/opnsense/core/issues/3567 so we can prevent additional requests on non 
changing data

OPNSense/core f9c2bdasrc/opnsense/scripts/netflow/lib parse.py

Insight. missing decode() when parsing ifconfig output leading to unexpected results. 
sqlite seems to store the binary in a varchar element, which looks right, but you can't 
compare it in your where statements. This  doesn't seem to lead to issues when there is 
already valid content in the timeserie table.

(cherry picked from commit 24dc2a82b5c82651c5c5925669c35ef4e5ceadf4)

OPNSense/core 24dc2a8src/opnsense/scripts/netflow/lib parse.py

Insight. missing decode() when parsing ifconfig output leading to unexpected results. 
sqlite seems to store the binary in a varchar element, which looks right, but you can't 
compare it in your where statements. This  doesn't seem to lead to issues when there is 
already valid content in the timeserie table.

OPNSense/core e914148src/etc/rc.syshook.d/early 05-update

firmware: this made things worse

OPNSense/core 29b383csrc/etc/inc filter.inc filter.lib.inc, src/etc/inc/plugins.inc.d pf.inc

filter/performance, improve loading speed by parsing legacy_interfaces_details() output 
through the plugin system. move verbose output while here. for 
https://github.com/opnsense/core/issues/3567

OPNSense/core 9acb0aesrc/etc/rc.syshook.d/early 05-update

firmware: this is better actually...

OPNSense/core 0467bf2src/etc/rc.syshook.d/early 05-update

firmware: disable configd during upgrade

PR: https://forum.opnsense.org/index.php?topic=13431.15

OPNSense/core 082b566src/etc/inc interfaces.inc

interfaces: performance for https://github.com/opnsense/core/issues/3567

* interfaces_addresses() only request single interface data when there's only one 
interface requested
* interface_configure() mtu check only needs a specific interface, don't request all

OPNSense/core 67ba6bfsrc/etc/inc interfaces.lib.inc

style fix, while working on https://github.com/opnsense/core/issues/3567, noticed a naming 
issue in legacy_interfaces_details()

OPNSense/core e6a228dsrc/etc/inc auth.inc

UI: auth.inc, use cached addresslist in referer check, for 
https://github.com/opnsense/core/issues/3567

This prevents ifconfig is executed on every request, which could take a long time when 
there are a lot of interfaces.
DeltaFile
+17-7src/etc/inc/auth.inc
+17-71 files

OPNSense/core 292358bsrc/etc/inc config.inc

add cache helper function in config.inc, needed for 
https://github.com/opnsense/core/issues/3567

get_cached_json_content() deserialize json data when the file is found and not yet 
expired, returns null otherwise.
Since there might be some spots in the code where this can be convenient, it seemed like a 
good idea to wrap it in a function within the legacy code base.
Maybe config.inc is not enterily the right spot for this, but util.inc is quite diverse 
already.

OPNSense/core a64d508src/www/javascript opnsense_legacy.js

Firewall, window_highlight_table_option(), safari seems to miss the border by one pixel, 
better to leave 1px spacing when animating the arrow to the right.

(cherry picked from commit a6cd706755c35c5b7740b269815cbb3bcd0b196c)

OPNSense/core bcef47dsrc/opnsense/scripts/shell banner.php

console: banner, don't call ifconfig for each interface. one of the usability issues in 
https://github.com/opnsense/core/issues/3567

When there are a lot of interfaces, these calls consume quite some time and eventually the 
output of legacy_interfaces_details() is what matters to all of them.

(cherry picked from commit e250b14ba701a14089d49f51d795f70086c60d2a)

OPNSense/core a6cd706src/www/javascript opnsense_legacy.js

Firewall, window_highlight_table_option(), safari seems to miss the border by one pixel, 
better to leave 1px spacing when animating the arrow to the right.

OPNSense/core e250b14src/opnsense/scripts/shell banner.php

console: banner, don't call ifconfig for each interface. one of the usability issues in 
https://github.com/opnsense/core/issues/3567

When there are a lot of interfaces, these calls consume quite some time and eventually the 
output of legacy_interfaces_details() is what matters to all of them.

OPNSense/core 3fd79fc. plist, src/etc/pkg/fingerprints/OPNsense/trusted pkg.opnsense.org.20190702

firmware: allow upgrade to version 19.7

OPNSense/core 37ee552src/etc/inc interfaces.inc

interfaces: further protect fallout triggered by 6ae356678dd

We can't be sure this won't happen again since the code makes
no effort to avoid such scenarios and happily moves on.  There's
probably more problematic code here down the line, but having
flushed out the other thing means we're on the right track.

(cherry picked from commit 4c4bdea7d4c21593272ae81e1c410ad6d8992072)

OPNSense/core 9bf2494src/etc/inc interfaces.inc

interfaces: fix ambiguity in get_parent_interface()

So having changed get_real_interface() to not check edge cases
for existing interfaces has bubbled up this check to the caller
get_parent_interface() which in turn made the check global.

The problem is that get_parent_interface() ran a hypothentical
code path through get_real_interface() and subsequently now
fails for dailup types leaving an empty interface.

That in turn caused some other refactoring to break where
individual device functions would take an argument or reload
all interfaces.  Now that dailup fiddles with get_parent_interface()
and overwrites the result of get_real_interface() in the main
interface_configure() run it would reconfigure previously
configured devices stripping their IP configuration in the
process.

Yikes!  :)

PR: https://forum.opnsense.org/index.php?topic=13442.0
(cherry picked from commit 6ae356678dde970b54f74fe8a58448a1904eaa29)

OPNSense/core 4c4bdeasrc/etc/inc interfaces.inc

interfaces: further protect fallout triggered by 6ae356678dd

We can't be sure this won't happen again since the code makes
no effort to avoid such scenarios and happily moves on.  There's
probably more problematic code here down the line, but having
flushed out the other thing means we're on the right track.

OPNSense/core 6ae3566src/etc/inc interfaces.inc

interfaces: fix ambiguity in get_parent_interface()

So having changed get_real_interface() to not check edge cases
for existing interfaces has bubbled up this check to the caller
get_parent_interface() which in turn made the check global.

The problem is that get_parent_interface() ran a hypothentical
code path through get_real_interface() and subsequently now
fails for dailup types leaving an empty interface.

That in turn caused some other refactoring to break where
individual device functions would take an argument or reload
all interfaces.  Now that dailup fiddles with get_parent_interface()
and overwrites the result of get_real_interface() in the main
interface_configure() run it would reconfigure previously
configured devices stripping their IP configuration in the
process.

Yikes!  :)

PR: https://forum.opnsense.org/index.php?topic=13442.0

OPNSense/core d79532b. +POST_INSTALL

firmware: add update syshook; closes #3288

(cherry picked from commit 73eccc5c42c4e5885e6723abcbf9dde037600506)
DeltaFile
+2-0+POST_INSTALL
+2-01 files

OPNSense/core f4c8c64src/etc/inc filter.inc, src/www system_general.php

firewall: pflog is doing strange things lately

Try to reload in case it can't open syslog and keep fully
reloading it to make sure that it stays operational.

(cherry picked from commit b2294eae1b45aba0965d91fac694849939d6d12b)

OPNSense/core b2294easrc/etc/inc filter.inc, src/www system_general.php

firewall: pflog is doing strange things lately

Try to reload in case it can't open syslog and keep fully
reloading it to make sure that it stays operational.

OPNSense/core e184a5esrc/opnsense firmware-upgrade

firmware: the goal is to go directly to 19.7

OPNSense/core 73eccc5. +POST_INSTALL

firmware: add update syshook; closes #3288
DeltaFile
+2-0+POST_INSTALL
+2-01 files