Illumos/gate e3a966fusr/src/uts/common/fs/smbclnt/netsmb smb_usr.c

11262 Memory leak in SMB client
Reviewed by: Roman Strashkin <roman.strashkin at nexenta.com>
Reviewed by: Yuri Pankov <yuri.pankov at nexenta.com>
Reviewed by: Garrett D'Amore <garrett at damore.org>
Approved by: Garrett D'Amore <garrett at damore.org>

Illumos/gate ae7ff7dusr/src/lib/libhotplug/common libhotplug.c

11118 libhotplug: NULL pointer errors
Reviewed by: Peter Tribble <peter.tribble at gmail.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate dd64585usr/src/lib/libzfs_core/common libzfs_core.c

11117 libzfs_core: NULL pointer errors
Reviewed by: Andy Stormont <astormont at racktopsystems.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 281eb3ausr/src/lib/libsecdb/common secdb.c chkauthattr.c

11114 libsecdb: NULL pointer errors
Reviewed by: Peter Tribble <peter.tribble at gmail.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate d5fa36ausr/src/cmd/sgs/crle/common print.c

11110 crle: NULL pointer errors
Reviewed by: Rob Johnston <rob.johnston at joyent.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate e2294b8usr/src/cmd/sgs/link_audit/common hash.c bindings.c

11103 link_audit: NULL pointer errors
Reviewed by: Norm Jacobs <naj at snapcon.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 430c2cdusr/src/uts/common/fs/fifofs fifovnops.c

6474 getupeercred causes spurious event port wakeups on FIFOs
Reviewed by: Garrett D'Amore <garrett at damore.org>
Reviewed by: Toomas Soome <tsoome at me.com>
Reviewed by: Gergő Doma <domag02 at gmail.com>
Approved by: Robert Mustacchi <rm at joyent.com>

Illumos/gate 5f5c35busr/src/cmd/sgs/liblddbg/common debug.c

11100 liblddbg: NULL pointer errors
Reviewed by: Norm Jacobs <naj at snapcon.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 344db6fusr/src/lib/libnsl/dial interface.c, usr/src/lib/libnsl/nss parse.c

11092 libnsl: NULL pointer errors
Reviewed by: Norm Jacobs <naj at snapcon.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate e86c3f0usr/src/lib/libc/port/gen event_port.c catopen.c, usr/src/lib/libc/port/rt mqueue.c

11091 libc: NULL pointer errors
Reviewed by: Norm Jacobs <naj at snapcon.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate ad24f9fusr/src/cmd/sgs/liblddbg/common statistics.c

11081 liblddbg: comparison between pointer and integer
Reviewed by: Gergő Doma <domag02 at gmail.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 0362cabusr/src/lib/libdisasm/common dis_sparc.c

11115 libdisasm: NULL pointer errors
Reviewed by: Peter Tribble <peter.tribble at gmail.com>
Approved by: Richard Lowe <richlowe at richlowe.net>

Illumos/gate 9a34674usr/src/boot/sys/boot/common disk.c disk.h, usr/src/boot/sys/boot/efi/loader main.c

11182 loader: Distinguish between "no partition" and "choose best partition" with a 
constant.
Reviewed by: John Levon <john.levon at joyent.com>
Reviewed by: Andy Fiddaman <andy at omniosce.org>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate a8412dcusr/src/boot Makefile.version, usr/src/boot/sys/boot/common module.c

11074 loader: mod_loadkld() error: we previously assumed 'last_file' could be null
Reviewed by: John Levon <john.levon at joyent.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 535ff4fusr/src/contrib/zlib zconf.h zutil.c

11047 zmod: make sure we use zmemcpy and friends
Reviewed by: Andy Fiddaman <andy at omniosce.org>
Reviewed by: Gergő Doma <domag02 at gmail.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate e207f0dusr/src/cmd/sgs/lex/common sub1.c ldefs.h

11111 lex: NULL pointer errors
Reviewed by: Rob Johnston <rob.johnston at joyent.com>
Approved by: Richard Lowe <richlowe at richlowe.net>

Illumos/gate 077efeausr/src/lib/nsswitch/nis/common switch_err.c

11239 usr/src/lib/nsswitch/nis/common/switch_err.c is unused
Reviewed by: Toomas Soome <tsoome at me.com>
Reviewed by: Gergő Doma <domag02 at gmail.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 6bf877ausr/src/uts/sun4/os startup.c, usr/src/uts/sun4u/os mach_startup.c

11225 There are no positrons
Reviewed by: Andy Stormont <astormont at racktopsystems.com>
Reviewed by: Gergő Doma <domag02 at gmail.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 37b221fusr/src/uts/common/fs/smbsrv smb_ofile.c

11248 Panic in smb_ofile_free after 11016
Reviewed by: Toomas Soome <tsoome at me.com>
Reviewed by: Gergő Doma <domag02 at gmail.com>
Reviewed by: Garrett D'Amore <garrett at damore.org>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 8123ce6usr/src Makefile.master, usr/src/tools/env illumos.sh

9996 use GCC 7 as default primary compiler
Reviewed by: Toomas Soome <tsoome at me.com>
Reviewed by: Peter Tribble <peter.tribble at gmail.com>
Approved by: Robert Mustacchi <rm at joyent.com>

Illumos/gate 67b1ef3usr/src/cmd/sgs/librtld_db/demo Makefile.targ, usr/src/cmd/sgs/librtld_db/demo/common bpt.c main.c

11238 librtld_db demos should work with gcc 7
Reviewed by: Robert Mustacchi <rm at joyent.com>
Approved by: Dan McDonald <damcd at joyent.com>

Illumos/gate 9f3a5a7usr/src/lib/libkrb5 Makefile

11246 krb5 makefiles should use INS or INS.file
Reviewed by: Jason King <jason.king at joyent.com>
Reviewed by: Gergő Doma <domag02 at gmail.com>
Approved by: Gordon Ross <gwr at nexenta.com>

Illumos/gate 0d2006eusr/src/lib/fm/topo/modules/common/usb topo_usb.c, usr/src/uts/common/io/usb/usba usba_bos.c parser.c

11177 usba should read the device binary object store
11178 USB topology could know about supported, minimum speeds
11179 usba parsing code should take const data pointers
11176 usba kernel module should be CERRWARN and smatch clean
Reviewed by: John Levon <john.levon at joyent.com>
Reviewed by: Rob Johnston <rob.johnston at joyent.com>
Approved by: Gordon Ross <gordon.ross at nexenta.com>

Illumos/gate 3e3ca1cusr/src/uts Makefile.mapfile, usr/src/uts/common/mapfiles ddi.mapfile README

10362 Catch kernel module undefined symbols at build time
Reviewed by: Jerry Jelinek <jerry.jelinek at joyent.com>
Reviewed by: Patrick Mooney <patrick.mooney at joyent.com>
Reviewed by: Gergő Doma <domag02 at gmail.com>
Reviewed by: Garrett D'Amore <garrett at damore.org>
Approved by: Garrett D'Amore <garrett at damore.org>

Illumos/gate 32106edusr/src/cmd/make/bin main.cc

11235 make -C fails under GCC7
Reviewed by: Robert Mustacchi <rm at joyent.com>
Reviewed by: Richard Lowe <richlowe at richlowe.net>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 0409f34usr/src/cmd/picl/plugins/sun4v/lib/snmp debug.c debug.h

11128 SPARC build fails for sun4v picl snmp plugin
Reviewed by: Toomas Soome <tsoome at me.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate be0ffdausr/src/tools/env illumos.sh, usr/src/tools/scripts nightly.sh nightly.1onbld

11221 Should be able to enable findunref without lint
Reviewed by: Joshua M. Clulow <josh at sysmgr.org>
Reviewed by: Toomas Soome <tsoome at me.com>
Reviewed by: John Levon <john.levon at joyent.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate e664589usr/src/man Makefile.man

11195 Lint old man pages for errors with mandoc
Reviewed by: Andy Fiddaman <omnios at citrus-it.co.uk>
Reviewed by: Robert Mustacchi <rm at joyent.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 0ae8c37usr/src/man/man1m syseventadm.1m

11194 syseventadm.1m: ERROR: using macro argument outside macro
Reviewed by: Andy Fiddaman <omnios at citrus-it.co.uk>
Reviewed by: Robert Mustacchi <rm at joyent.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 1f2dca3usr/src/man/man9f cmn_err.9f

11193 cmn_err.9f: UNSUPP: unsupported escape sequences
Reviewed by: Andy Fiddaman <omnios at citrus-it.co.uk>
Reviewed by: Robert Mustacchi <rm at joyent.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 2da8e96usr/src/man/man1m zpool.1m

11192 zpool.1m: UNSUPP: unsupported escape sequence: \?
Reviewed by: Andy Fiddaman <omnios at citrus-it.co.uk>
Reviewed by: Robert Mustacchi <rm at joyent.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate cf26d36usr/src/man/man1m zfs.1m

11191 zfs.1m: UNSUPP: unsupported escape sequence: \?
Reviewed by: Andy Fiddaman <omnios at citrus-it.co.uk>
Reviewed by: Robert Mustacchi <rm at joyent.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 807b45fusr/src/lib/libsocket/inet rcmd.c

11093 libsocket: NULL pointer errors
Reviewed by: Ryan Zezeski <rpz at joyent.com>
Reviewed by: Garrett D'Amore <garrett at damore.org>
Approved by: Garrett D'Amore <garrett at damore.org>

Illumos/gate 1160dcfusr/src/lib/smbsrv/libfksmbsrv/common fksmb_encrypt_pkcs.c, usr/src/uts/common/fs/smbsrv smb3_encrypt.c smb2_dispatch.c

11018 SMB3 Encryption
Reviewed by: Gordon Ross <gordon.ross at nexenta.com>
Reviewed by: Evan Layton <evan.layton at nexenta.com>
Reviewed by: Roman Strashkin <roman.strashkin at nexenta.com>
Approved by: Garrett D'Amore <garrett at damore.org>

Illumos/gate 5419c03usr/src/lib/smbsrv/libsmb/common smb_cfg.c

11019 Enable SMB3 server by default
Reviewed by: Gordon Ross <gordon.ross at nexenta.com>
Reviewed by: Evan Layton <evan.layton at nexenta.com>
Approved by: Garrett D'Amore <garrett at damore.org>

Illumos/gate 0ab6f51usr/src/contrib/zlib deflate.c

11204 smatch issue in zlib/deflate.c
Reviewed by: Toomas Soome <tsoome at me.com>
Reviewed by: Gergő Doma <domag02 at gmail.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 479c108usr/src/uts/common/fs/smbsrv smb2_aapl.c, usr/src/uts/common/smbsrv smb2_aapl.h

11017 Support Apple FULL_SYNC feature
Reviewed by: Matt Barden <matt.barden at nexenta.com>
Reviewed by: Evan Layton <evan.layton at nexenta.com>
Approved by: Garrett D'Amore <garrett at damore.org>

Illumos/gate 94047d4usr/src/cmd/smbsrv/testoplock tol_main.c, usr/src/uts/common/fs/smbsrv smb_cmn_oplock.c smb_oplock.c

11016 SMB2 oplock leases
Reviewed by: Matt Barden <matt.barden at nexenta.com>
Reviewed by: Evan Layton <evan.layton at nexenta.com>
Reviewed by: Roman Strashkin <roman.strashkin at nexenta.com>
Approved by: Garrett D'Amore <garrett at damore.org>

Illumos/gate 148d1a4usr/src/uts/common/fs/smbsrv smb2_dispatch.c smb2_change_notify.c, usr/src/uts/common/smbsrv smb_ktypes.h smb2_kproto.h

11015 SMB2 async redesign
Reviewed by: Gordon Ross <gwr at nexenta.com>
Reviewed by: Evan Layton <evan.layton at nexenta.com>
Reviewed by: Roman Strashkin <roman.strashkin at nexenta.com>
Approved by: Garrett D'Amore <garrett at damore.org>

Illumos/gate d2488feusr/src/uts/common/fs/smbsrv smb_mangle_name.c smb_node.c

11014 should pass smtorture smb2.create.blob
Reviewed by: Matt Barden <matt.barden at nexenta.com>
Reviewed by: Evan Layton <evan.layton at nexenta.com>
Approved by: Garrett D'Amore <garrett at damore.org>

Illumos/gate d6390efusr/src/lib/smbsrv/libmlsvc/common libmlsvc.h, usr/src/uts/common/smb ntstatus.h

11013 Update NT status codes
Reviewed by: Evan Layton <evan.layton at nexenta.com>
Reviewed by: Kevin Crowe <kevin.crowe at nexenta.com>
Reviewed by: Matt Barden <matt.barden at nexenta.com>
Approved by: Garrett D'Amore <garrett at damore.org>

Illumos/gate 811599ausr/src/cmd/mdb/common/modules/smbsrv smbsrv.c, usr/src/uts/common/fs/smbsrv smb_ofile.c smb2_durable.c

11011 SMB2/3 durable handles
Portions contributed by: Gordon Ross <gwr at nexenta.com>
Reviewed by: Gordon Ross <gwr at nexenta.com>
Reviewed by: Kevin Crowe <kevin.crowe at nexenta.com>
Reviewed by: Evan Layton <evan.layton at nexenta.com>
Reviewed by: Roman Strashkin <roman.strashkin at nexenta.com>
Reviewed by: Rick McNeal <rick.mcneal at nexenta.com>
Approved by: Garrett D'Amore <garrett at damore.org>

Illumos/gate 6f58980usr/src/uts/common/fs/smbsrv smb2_lock.c smb_ofile.c, usr/src/uts/common/smbsrv smb_ktypes.h

11012 SMB resilient handle lock replay
Reviewed by: Matt Barden <matt.barden at nexenta.com>
Reviewed by: Kevin Crowe <kevin.crowe at nexenta.com>
Approved by: Garrett D'Amore <garrett at damore.org>

Illumos/gate 22817acusr/src/uts/common/fs/smbsrv smb_create.c

11008 SMB1 Create_Temp should return an untagged ASCII string
Reviewed by: Gordon Ross <gwr at nexenta.com>
Approved by: Garrett D'Amore <garrett at damore.org>

Illumos/gate 5cb2894usr/src/cmd/mdb/common/modules/smbsrv smbsrv.c, usr/src/uts/common/fs/smbsrv smb_node.c smb_common_open.c

11010 Obsolete SMB server work-around for ZFS read-only
Reviewed by: Matt Barden <matt.barden at nexenta.com>
Reviewed by: Evan Layton <evan.layton at nexenta.com>
Approved by: Garrett D'Amore <garrett at damore.org>

Illumos/gate c51c88busr/src/cmd/smbsrv/fksmbd fksmbd_kmod.c, usr/src/lib/smbsrv/libfksmbsrv/common fksmb_sign_pkcs.c

11007 SMB3 signing
Reviewed by: Gordon Ross <gordon.ross at nexenta.com>
Reviewed by: Matt Barden <matt.barden at nexenta.com>
Reviewed by: Dan Fields <dan.fields at nexenta.com>
Reviewed by: Evan Layton <evan.layton at nexenta.com>
Reviewed by: Roman Strashkin <roman.strashkin at nexenta.com>
Approved by: Garrett D'Amore <garrett at damore.org>

Illumos/gate 49d8359usr/src/lib/smbsrv/libfksmbsrv/common fake_vop.c, usr/src/uts/common/fs/smbsrv smb_node.c smb_common_open.c

11009 delete_on_close should be acted on earlier
Reviewed by: Gordon Ross <gwr at nexenta.com>
Approved by: Garrett D'Amore <garrett at damore.org>

Illumos/gate 066a1a3usr/src/cmd/ptools Makefile.bld

11211 10946 broke nightly if doing both -nd and DEBUG
Reviewed by: Dan McDonald <danmcd at joyent.com>
Approved by: Robert Mustacchi <rm at joyent.com>

Illumos/gate e32fc5busr/src/lib/libc/sparc Makefile.com, usr/src/lib/libc/sparcv9 Makefile.com

11097 SPARC needs some instances of POST_PROCESS_O to be POST_PROCESS_S_O
Reviewed by: Andrew Stormont <andyjstormont at gmail.com>
Reviewed by: Norm Jacobs <naj at snapcon.com>
Reviewed by: Andy Fiddaman <omnios at citrus-it.co.uk>
Reviewed by: Gergő Doma <domag02 at gmail.com>
Approved by: Richard Lowe <richlowe at richlowe.net>

Illumos/gate 96dd34fusr/src/ucblib/libucb Makefile.com, usr/src/ucblib/libucb/sparc Makefile

11136 SPARC build fails with ctfconvert error in libucb
Reviewed by: Toomas Soome <tsoome at me.com>
Reviewed by: Gergő Doma <domag02 at gmail.com>
Approved by: Richard Lowe <richlowe at richlowe.net>