Illumos/gate 3ade830usr/src/uts/common/io ptem.c

16529 TIOCGWINSZ returns EINVAL on a freshly-created pty
Reviewed by: Andy Fiddaman <illumos at fiddaman.net>
Reviewed by: Toomas Soome <tsoome at me.com>
Approved by: Dan McDonald <danmcd at mnx.io>
DeltaFile
+0-9usr/src/uts/common/io/ptem.c
+0-91 files

Illumos/gate e2a8479usr/src/uts/common/io clone.c, usr/src/uts/intel/clone Makefile

16516 clone: smatch errors
Reviewed by: Gordon Ross <gordon.w.ross at gmail.com>
Approved by: Dan McDonald <danmcd at mnx.io>
DeltaFile
+3-3usr/src/uts/common/io/clone.c
+0-3usr/src/uts/intel/clone/Makefile
+3-62 files

Illumos/gate 98f0a99usr/src/uts/common/io/scsi/adapters/lmrc lmrc_reg.h lmrc_phys.h, usr/src/uts/common/sys/scsi/adapters/mfi mfi.h mfi_evt.h

16477 lmrc: move MFI definitions into their own headers
Reviewed by: Bill Sommerfeld <sommerfeld at hamachi.org>
Reviewed by: Gordon Ross <Gordon.W.Ross at gmail.com>
Reviewed by: Jason King <jason.brian.king+illumos at gmail.com>
Approved by: Dan McDonald <danmcd at mnx.io>
DeltaFile
+833-0usr/src/uts/common/sys/scsi/adapters/mfi/mfi.h
+3-784usr/src/uts/common/io/scsi/adapters/lmrc/lmrc_reg.h
+310-0usr/src/uts/common/sys/scsi/adapters/mfi/mfi_evt.h
+260-0usr/src/uts/common/sys/scsi/adapters/mfi/mfi_pd.h
+238-0usr/src/uts/common/sys/scsi/adapters/mfi/mfi_ld.h
+3-219usr/src/uts/common/io/scsi/adapters/lmrc/lmrc_phys.h
+1,647-1,00311 files not shown
+2,078-1,27417 files

Illumos/gate ce43180usr/src/boot Makefile.version, usr/src/boot/efi/loader framebuffer.c

14320 loader.efi: Do not use as frame buffer BLT-only GOPs.
Reviewed by: Toomas Soome <tsoome at me.com>
Reviewed by: Sebastian Wiedenroth <wiedi at frubar.net>
Approved by: Gordon Ross <gordon.w.ross at gmail.com>
DeltaFile
+18-5usr/src/boot/efi/loader/framebuffer.c
+1-1usr/src/boot/Makefile.version
+19-62 files

Illumos/gate 4e0cc57usr/src/common/crypto/sha1 sha1.c, usr/src/test/crypto-tests/tests/longhash longhash.c

16350 SHA1 may produce incorrect hashes if given a 2^29 byte input
Reviewed by: Robert Mustacchi <rm+illumos at fingolfin.org>
Approved by: Gordon Ross <gordon.w.ross at gmail.com>
DeltaFile
+55-3usr/src/test/crypto-tests/tests/longhash/longhash.c
+30-6usr/src/common/crypto/sha1/sha1.c
+85-92 files

Illumos/gate b960b5eusr/src/cmd/svc/common notify_params.c, usr/src/cmd/svc/svccfg svccfg.h svccfg.y

16528 clean up low-hanging warnings in svccfg(8)
Reviewed by: Bill Sommerfeld <sommerfeld at hamachi.org>
Reviewed by: Jason King <jason.brian.king+illumos at gmail.com>
Reviewed by: Andy Fiddaman <illumos at fiddaman.net>
Approved by: Dan McDonald <danmcd at mnx.io>
DeltaFile
+121-100usr/src/cmd/svc/svccfg/svccfg.h
+5-3usr/src/cmd/svc/common/notify_params.c
+3-3usr/src/cmd/svc/svccfg/svccfg.y
+3-3usr/src/cmd/svc/svccfg/Makefile
+1-1usr/src/cmd/svc/svccfg/svccfg_libscf.c
+1-0usr/src/cmd/svc/svccfg/svccfg_main.c
+134-1106 files

Illumos/gate c7685b3usr/src/cmd/mdb/common/modules/ip ip.c

16510 mdb incorrectly prints the IPv6 Traffic Class
Reviewed by: Gordon Ross <Gordon.W.Ross at gmail.com>
Reviewed by: Andy Fiddaman <illumos at fiddaman.net>
Approved by: Robert Mustacchi <rm at fingolfin.org>
DeltaFile
+2-1usr/src/cmd/mdb/common/modules/ip/ip.c
+2-11 files

Illumos/gate 89cf0c2usr/src/uts/common/inet/ipf fil.c ip_proxy.c, usr/src/uts/common/inet/ipf/netinet ip_compat.h

16521 ipf kernel panic while initialising statistics on low memory system
Reviewed by: Bill Sommerfeld <sommerfeld at hamachi.org>
Reviewed by: Toomas Soome <tsoome at me.com>
Approved by: Patrick Mooney <pmooney at pfmooney.com>
DeltaFile
+5-1usr/src/uts/common/inet/ipf/fil.c
+2-0usr/src/uts/common/inet/ipf/ip_proxy.c
+2-0usr/src/uts/common/inet/ipf/netinet/ip_compat.h
+9-13 files

Illumos/gate dadf5efusr/src/test/zfs-tests/tests/functional/cli_root/zfs_property zfs_written_property_001_pos.ksh

12023 zfs test zfs_written_property_001_pos can fail
Portions contributed by: John Wren Kennedy <john.kennedy at delphix.com>
Reviewed by: Gordon Ross <Gordon.W.Ross at gmail.com>
Approved by: Dan McDonald <danmcd at mnx.io>
DeltaFile
+13-13usr/src/test/zfs-tests/tests/functional/cli_root/zfs_property/zfs_written_property_001_pos.ksh
+13-131 files

Illumos/gate 72af5a4usr/src/lib/libc/port/locale strftime.c, usr/src/pkg/manifests system-test-libctest.p5m

16352 strftime_l() should be more careful with pointer arithmetic
Reviewed by: Gordon Ross <Gordon.W.Ross at gmail.com>
Approved by: Robert Mustacchi <rm at fingolfin.org>
DeltaFile
+89-0usr/src/test/libc-tests/tests/ascftime.c
+24-2usr/src/lib/libc/port/locale/strftime.c
+2-0usr/src/pkg/manifests/system-test-libctest.p5m
+2-0usr/src/test/libc-tests/runfiles/default.run
+1-0usr/src/test/libc-tests/tests/Makefile
+118-25 files

Illumos/gate f386ca6usr/src/cmd/cmd-inet/usr.sbin/snoop snoop_ip.c

16508 snoop incorrectly prints the IPv6 Traffic Class
Reviewed by: Toomas Soome <tsoome at me.com>
Reviewed by: Andy Fiddaman <illumos at fiddaman.net>
Reviewed by: Vitaliy Gusev <gusev.vitaliy at gmail.com>
Reviewed by: Bill Sommerfeld <sommerfeld at hamachi.org>
Approved by: Gordon Ross <gordon.w.ross at gmail.com>
DeltaFile
+5-4usr/src/cmd/cmd-inet/usr.sbin/snoop/snoop_ip.c
+5-41 files

Illumos/gate 1696d86usr/src/cmd/cmd-inet/usr.bin/nc netcat.c, usr/src/man/man1 nc.1

16491 netcat should support setting the outgoing and minimum TTL
16501 netcat should support setting IPV6_TCLASS for ipv6 sockets
16507 nc missing TCP MD5 in usage and help
Reviewed by: Andy Fiddaman <illumos at fiddaman.net>
Reviewed by: Toomas Soome <tsoome at me.com>
Reviewed by: Dan Cross <cross at oxidecomputer.com>
Reviewed by: Bill Sommerfeld <sommerfeld at hamachi.org>
Approved by: Dan McDonald <danmcd at mnx.io>
DeltaFile
+112-32usr/src/cmd/cmd-inet/usr.bin/nc/netcat.c
+25-3usr/src/man/man1/nc.1
+137-352 files

Illumos/gate 4ac140busr/src/uts/common/fs/zfs vdev.c vdev_label.c

16502 panic in zfs:abd_iter_map
Reviewed by: Andy Fiddaman <illumos at fiddaman.net>
Reviewed by: Toomas Soome <tsoome at me.com>
Approved by: Gordon Ross <gordon.w.ross at gmail.com>
DeltaFile
+12-0usr/src/uts/common/fs/zfs/vdev.c
+10-0usr/src/uts/common/fs/zfs/vdev_label.c
+2-5usr/src/uts/common/fs/zfs/vdev_indirect.c
+24-53 files

Illumos/gate 3887472usr/src/uts/common/inet/tcp tcp_sig.c

16519 panic when removing SADB entry with tcpkey delete
Reviewed by: Robert Mustacchi <rm+illumos at fingolfin.org>
Reviewed by: Bill Sommerfeld <sommerfeld at hamachi.org>
Approved by: Gordon Ross <gordon.w.ross at gmail.com>
DeltaFile
+10-13usr/src/uts/common/inet/tcp/tcp_sig.c
+10-131 files

Illumos/gate eac40bbexception_lists closed-bins

16498 closed nfs dmod/kmod are still delivered
Reviewed by: Andy Fiddaman <illumos at fiddaman.net>
Reviewed by: Bill Sommerfeld <sommerfeld at hamachi.org>
Approved by: Robert Mustacchi <rm at fingolfin.org>
DeltaFile
+2-0exception_lists/closed-bins
+2-01 files

Illumos/gate a87f5a4usr/src/uts/common/rpc clnt_clts.c

16387 CLSET_NODELAYONERR not set if udp transport is used.
Reviewed by: Dan McDonald <danmcd at mnx.io>
Reviewed by: Gordon Ross <gordon.w.ross at gmail.com>
Approved by: Patrick Mooney <pmooney at pfmooney.com>
DeltaFile
+11-0usr/src/uts/common/rpc/clnt_clts.c
+11-01 files

Illumos/gate e0c5eaausr/src/common/nvme nvme_log.c

16484 libnvme should take care of unaligned log page sizes
Reviewed by: Michael Zeller <mike at mikezeller.net>
Reviewed by: Bill Sommerfeld <sommerfeld at hamachi.org>
Approved by: Gordon Ross <gordon.w.ross at gmail.com>
DeltaFile
+15-2usr/src/common/nvme/nvme_log.c
+15-21 files

Illumos/gate 851677fusr/src/common/smbios smb_info.c, usr/src/test/util-tests/tests/smbios smbios_test_chassis.c smbios.c

16485 smbios chassis SKU logic is accidentally required
Reviewed by: Gordon Ross <gordon.w.ross at gmail.com>
Reviewed by: Patrick Mooney <pmooney at pfmooney.com>
Approved by: Dan McDonald <danmcd at mnx.io>
DeltaFile
+39-7usr/src/test/util-tests/tests/smbios/smbios_test_chassis.c
+25-16usr/src/common/smbios/smb_info.c
+16-8usr/src/test/util-tests/tests/smbios/smbios.c
+1-0usr/src/test/util-tests/tests/smbios/smbios_test.h
+81-314 files

Illumos/gate 1edba51usr/src/cmd/cmd-inet/usr.sbin/ipsecutils ipseckey.c, usr/src/lib/libipsecutil/common ipsec_util.c

16455 want TCP_MD5SIG socket option
Reviewed by: Robert Mustacchi <rm+illumos at fingolfin.org>
Reviewed by: Dan McDonald <danmcd at mnx.io>
Approved by: Gordon Ross <gordon.w.ross at gmail.com>
DeltaFile
+652-792usr/src/man/man1/nc.1
+907-0usr/src/uts/common/inet/tcp/tcp_sig.c
+690-0usr/src/test/os-tests/tests/tcpsig/tcpsig.c
+312-116usr/src/cmd/cmd-inet/usr.sbin/ipsecutils/ipseckey.c
+232-43usr/src/lib/libipsecutil/common/ipsec_util.c
+262-0usr/src/man/man8/tcpkey.8
+3,055-95149 files not shown
+4,160-1,14255 files

Illumos/gate 486c6fdusr/src/cmd/latencytop display.c stat.c, usr/src/cmd/latencytop/common display.c stat.c

16446 dtrace consumers should not be isaexec'd
Reviewed by: Andy Fiddaman <illumos at fiddaman.net>
Reviewed by: Dan McDonald <danmcd at mnx.io>
Approved by: Robert Mustacchi <rm at fingolfin.org>
DeltaFile
+1,068-0usr/src/cmd/latencytop/display.c
+0-1,068usr/src/cmd/latencytop/common/display.c
+1,050-0usr/src/cmd/latencytop/stat.c
+0-1,050usr/src/cmd/latencytop/common/stat.c
+840-0usr/src/cmd/latencytop/table.c
+0-840usr/src/cmd/latencytop/common/table.c
+2,958-2,95848 files not shown
+5,550-6,80954 files

Illumos/gate bb65110usr/src/cmd/dtrace/test/tst/common/sdt tst.sdtargs_tail_call.d tst.sdtargs_tail_call.c, usr/src/uts/common/sys sdt_impl.h

16480 krtld doesn't properly handle tail called sdt probes on x86
Reviewed by: Patrick Mooney <pmooney at pfmooney.com>
Reviewed by: Toomas Soome <tsoome at me.com>
Approved by: Robert Mustacchi <rm at fingolfin.org>
DeltaFile
+78-0usr/src/cmd/dtrace/test/tst/common/sdt/tst.sdtargs_tail_call.d
+43-0usr/src/cmd/dtrace/test/tst/common/sdt/tst.sdtargs_tail_call.c
+31-2usr/src/uts/common/syscall/uadmin.c
+14-6usr/src/uts/intel/amd64/krtld/kobj_reloc.c
+15-0usr/src/uts/intel/dtrace/sdt.c
+14-0usr/src/uts/common/sys/sdt_impl.h
+195-82 files not shown
+202-118 files

Illumos/gate 7f9dc0eusr/src/lib/libc/inc thr_debug.h libc.h, usr/src/lib/libc/port/threads thr.c synch.c

16192 Retire libc's thr_debug.h in favor of <sys/debug.h>
Reviewed by: Robert Mustacchi <rm+illumos at fingolfin.org>
Approved by: Dan McDonald <danmcd at mnx.io>
DeltaFile
+0-42usr/src/lib/libc/inc/thr_debug.h
+14-1usr/src/lib/libc/inc/libc.h
+6-6usr/src/lib/libc/port/threads/thr.c
+6-6usr/src/lib/libc/port/threads/synch.c
+6-5usr/src/uts/common/sys/debug.h
+5-5usr/src/lib/libc/inc/asyncio.h
+37-6513 files not shown
+75-9419 files

Illumos/gate b9d2f05usr/src/uts/common/fs/sockfs socktpi.c socksubr.c, usr/src/uts/intel/sockfs Makefile

16340 sockfs: label defined but not used
Reviewed by: Bill Sommerfeld <sommerfeld at hamachi.org>
Reviewed by: Dan Cross <cross at oxidecomputer.com>
Reviewed by: Sebastian Wiedenroth <wiedi at frubar.net>
Approved by: Dan McDonald <danmcd at mnx.io>
DeltaFile
+1-8usr/src/uts/common/fs/sockfs/socktpi.c
+0-4usr/src/uts/intel/sockfs/Makefile
+1-1usr/src/uts/common/fs/sockfs/socksubr.c
+1-1usr/src/uts/common/fs/sockfs/socksyscalls.c
+3-144 files

Illumos/gate 369bcc4usr/src/uts/common/fs/sockfs socksyscalls.c socktpi.c, usr/src/uts/intel/sockfs Makefile

16339 sockfs: variable may be used uninitialized
Reviewed by: Jason King <jason.brian.king+illumos at gmail.com>
Reviewed by: Bill Sommerfeld <sommerfeld at hamachi.org>
Approved by: Robert Mustacchi <rm at fingolfin.org>
DeltaFile
+4-3usr/src/uts/common/fs/sockfs/socksyscalls.c
+2-2usr/src/uts/common/fs/sockfs/socktpi.c
+1-1usr/src/uts/common/fs/sockfs/sockcommon_subr.c
+1-1usr/src/uts/common/fs/sockfs/sockcommon_sops.c
+0-1usr/src/uts/intel/sockfs/Makefile
+8-85 files

Illumos/gate c599112usr/src/lib/rpcsec_gss rpcsec_gss.c, usr/src/uts/common/rpc/sec_gss rpcsec_gss.c

15023 __rpc_gss_seccreate() doesn't set options_ret->major/minor_status on failure
Reviewed by: Toomas Soome <tsoome at me.com>
Approved by: Robert Mustacchi <rm at fingolfin.org>
DeltaFile
+17-2usr/src/lib/rpcsec_gss/rpcsec_gss.c
+15-1usr/src/uts/common/rpc/sec_gss/rpcsec_gss.c
+32-32 files

Illumos/gate e824907usr/src/man/man4p ip.4p, usr/src/test/os-tests/tests/minttl minttl.c minttl_err.c

16454 want IP_MINTTL socket option
16474 sctp returns wrong error for IPPROTO_IP on non-IPv4
Reviewed by: C Fraire <cfraire at me.com>
Reviewed by: Andy Fiddaman <illumos at fiddaman.net>
Reviewed by: Dan McDonald <danmcd at mnx.io>
Reviewed by: Jason King <jason.brian.king+illumos at gmail.com>
Approved by: Gordon Ross <gordon.w.ross at gmail.com>
DeltaFile
+747-0usr/src/test/os-tests/tests/minttl/minttl.c
+288-0usr/src/test/os-tests/tests/minttl/minttl_err.c
+56-0usr/src/test/os-tests/tests/minttl/Makefile
+28-3usr/src/uts/common/inet/ip/conn_opt.c
+29-1usr/src/uts/common/inet/ip/ip.c
+25-2usr/src/man/man4p/ip.4p
+1,173-622 files not shown
+1,323-3128 files

Illumos/gate 02ac56eusr/src/cmd/fs.d/nfs/tests test_svc_tp_create.c Makefile.com, usr/src/cmd/fs.d/nfs/tests/rpcsec_gss_conn rpcsec_gss_conn.c

15022 rpcsec_gss always calls global-zone GSSD for gss_accept_sec_context
Reviewed by: Evan Layton <elayton at tintri.com>
Reviewed by: Gordon Ross <gordon.ross at tintri.com>
Reviewed by: Toomas Soome <tsoome at me.com>
Approved by: Gordon Ross <gordon.w.ross at gmail.com>
DeltaFile
+332-0usr/src/cmd/fs.d/nfs/tests/test_svc_tp_create/test_svc_tp_create.c
+0-332usr/src/cmd/fs.d/nfs/tests/test_svc_tp_create.c
+172-0usr/src/cmd/fs.d/nfs/tests/rpcsec_gss_conn/rpcsec_gss_conn.c
+129-14usr/src/uts/common/rpc/sec_gss/svc_rpcsec_gss.c
+46-0usr/src/cmd/fs.d/nfs/tests/Makefile.com
+22-21usr/src/cmd/fs.d/nfs/tests/Makefile
+701-3673 files not shown
+757-3689 files

Illumos/gate 21ca3fausr/src/cmd/ptools/ptree ptree.c

16495 ptree -g should be more willing to use UTF-8 box characters
Reviewed by: Rich Lowe <richlowe at richlowe.net>
Reviewed by: Peter Tribble <peter.tribble at gmail.com>
Reviewed by: Jason King <jason.brian.king+illumos at gmail.com>
Reviewed by: Toomas Soome <tsoome at me.com>
Approved by: Gordon Ross <gordon.w.ross at gmail.com>
DeltaFile
+7-7usr/src/cmd/ptools/ptree/ptree.c
+7-71 files

Illumos/gate 558556busr/src/tools/ndrgen ndr_gen.c

16490 Overlapping strlcpy in ndrgen
Reviewed by: Gordon Ross <Gordon.W.Ross at gmail.com>
Reviewed by: Hans Rosenfeld <rosenfeld at grumpf.hope-2000.org>
Reviewed by: Toomas Soome <tsoome at me.com>
Approved by: Patrick Mooney <pmooney at pfmooney.com>
DeltaFile
+2-1usr/src/tools/ndrgen/ndr_gen.c
+2-11 files

Illumos/gate 67cac09usr/src/uts/common/io/mac mac.c mac_sched.c

16469 `mac_rx_flow` should attempt to preserve mblk_t chains
Reviewed by: Robert Mustacchi <rm at fingolfin.org>
Reviewed by: Andy Fiddaman <illumos at fiddaman.net>
Reviewed by: Jason King <jason.brian.king+illumos at gmail.com>
Approved by: Dan McDonald <danmcd at mnx.io>
DeltaFile
+63-22usr/src/uts/common/io/mac/mac.c
+2-1usr/src/uts/common/io/mac/mac_sched.c
+65-232 files