Illumos/gate 4c63bf6usr/src/lib/libzfs/common libzfs_pool.c

11558 libzfs: allow device removal feature for root pool
Reviewed by: Andy Fiddaman <andy at omniosce.org>
Reviewed by: Jerry Jelinek <jerry.jelinek at joyent.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 4c52839usr/src/boot/lib/libstand printf.c

11565 loader: this statement may fall through
Reviewed by: Andrew Stormont <andyjstormont at gmail.com>
Reviewed by: Robert Mustacchi <robert.mustacchi at joyent.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 05876afusr/src/common/bzip2 bzlib.c

11566 bzip2: unused parameter 'opaque'
Reviewed by: Robert Mustacchi <rm at joyent.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate db8c8c3usr/src/boot/sys/boot/libficl Makefile.com

11567 loader: ficl vm.o volatile argument warning
Reviewed by: Andrew Stormont <andyjstormont at gmail.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 2052a1fusr/src/boot/sys/boot/i386/libi386 pxe.c

11568 loader: pxe.c missing initializer
Reviewed by: C Fraire <cfraire at me.com>
Reviewed by: Rob Johnston <rob.johnston at joyent.com>
Approved by: Robert Mustacchi <rm at joyent.com>

Illumos/gate 8d94f65usr/src/uts/common/fs/smbsrv smb2_durable.c smb_tree.c

11031 SMB3 persistent handles
Reviewed by: Matt Barden <matt.barden at nexenta.com>
Reviewed by: Evan Layton <evan.layton at nexenta.com>
Reviewed by: Roman Strashkin <roman.strashkin at nexenta.com>
Reviewed by: Yuri Pankov <yuri.pankov at nexenta.com>
Reviewed by: Joyce McIntosh <joyce.mcintosh at nexenta.com>
Reviewed by: Jason King <jason.king at joyent.com>
Approved by: Garrett D'Amore <garrett at damore.org>

Illumos/gate 2f57b5eusr/src Makefile.master

11532 Makefile.master: add gcc9 support flags
Reviewed by: Peter Tribble <peter.tribble at gmail.com>
Reviewed by: Alexander Pyhalov <apyhalov at gmail.com>
Reviewed by: John Levon <john.levon at joyent.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate f8296c6usr/src/uts/common/io/vioblk vioblk.c, usr/src/uts/common/io/vioif vioif.c vioif.h

11329 improved Virtio framework
10012 vioblk should not accept an all-zero serial number
7366 vioif happily creates rx descriptors until it consumes all memory
Reviewed by: Robert Mustacchi <rm at joyent.com>
Approved by: Richard Lowe <richlowe at richlowe.net>

Illumos/gate d3b5f56usr/src Makefile.noget Makefile.master, usr/src/cmd/zlogin Makefile

11528 Makefile.noget can get gone
11529 Use -Wno-maybe-initialized
Reviewed by: Peter Tribble <peter.tribble at gmail.com>
Reviewed by: Toomas Soome <tsoome at me.com>
Approved by: Robert Mustacchi <rm at joyent.com>

Illumos/gate c4ccc1fusr/src/cmd/picl/plugins/sun4u/snowbird/frutree piclfrutree.c, usr/src/cmd/picl/plugins/sun4u/snowbird/lib/fruaccess libfruaccess.c

11226 Remove NetraCT support
Reviewed by: Gergő Doma <domag02 at gmail.com>
Reviewed by: Gordon Ross <gwr at nexenta.com>
Reviewed by: Andy Fiddaman <andy at omniosce.org>
Approved by: Garrett D'Amore <garrett at damore.org>

Illumos/gate dcfeff9usr/src/boot/sys/boot/efi/loader/arch/amd64 ldscript.amd64

11561 loader script needs to place .eh_frame after .text
Reviewed by: Toomas Soome <tsoome at me.com>
Approved by: Robert Mustacchi <rm at joyent.com>

Illumos/gate a8ffe49usr/src/boot Makefile.version, usr/src/boot/sys/boot/i386/gptzfsboot zfsboot.c

11555 gptzfsboot: boot prompt is not refreshed on device change
Reviewed by: C Fraire <cfraire at me.com>
Reviewed by: Andy Fiddaman <andy at omniosce.org>
Approved by: Robert Mustacchi <rm at joyent.com>

Illumos/gate 79940ffusr/src/uts/common/inet/ip ip_attr.c

11556 ip_attr.c functions need to not dereference conn_ixa directly after lock drop
Reviewed by: Jason King <jbk at joyent.com>
Reviewed by: Mike Gerdts <mgerdts at joyent.com>
Reviewed by: Andy Fiddaman <andy at omniosce.org>
Approved by: Gordon Ross <gwr at nexenta.com>

Illumos/gate fe94961usr/src/tools/scripts wsdiff.py

10540 wsdiff much slower under python3 than python2
Reviewed by: Andy Fiddaman <omnios at citrus-it.co.uk>
Reviewed by: Richard Lowe <richlowe at richlowe.net>
Approved by: Robert Mustacchi <rm at joyent.com>

Illumos/gate c1064fdusr/src/uts/common/fs/zfs vdev.c

11541 allocation_classes feature must be enabled to add log device
Reviewed by: C Fraire <cfraire at me.com>
Reviewed by: Kody Kantor <kody.kantor at joyent.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate c023f65usr/src/boot Makefile.version, usr/src/boot/lib/libstand/zfs zfsimpl.c Makefile.inc

10166 loader: support com.delphix:removing
Reviewed by: Jerry Jelinek <jerry.jelinek at joyent.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 582237eusr/src/tools/smatch Makefile

11548 11506 breaks the SPARC build
Reviewed by: Igor Kozhukhov <igor at dilos.org>
Reviewed by: John Levon <john.levon at joyent.com>
Approved by: Robert Mustacchi <rm at joyent.com>

Illumos/gate c6dd35dusr/src/boot Makefile.version, usr/src/boot/sys/boot/efi/libefi efi_console.c

11549 loader: smatch error: efi_cons_cursor(): uninitialized symbol 'row' and 'col'
Reviewed by: Yuri Pankov <yuri.pankov at nexenta.com>
Reviewed by: John Levon <john.levon at joyent.com>
Approved by: Robert Mustacchi <rm at joyent.com>

Illumos/gate bf8d275usr/src/uts/common/io/ib/ibnex ibnex_ioctl.c ibnex.c

10721 ib: NULL pointer errors
Reviewed by: Robert Mustacchi <robert.mustacchi at joyent.com>
Reviewed by: Gordon Ross <gordon.ross at nexenta.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 8bb3e7eusr/src/cmd/praudit format.c main.c, usr/src/man/man1m praudit.1m

9830 praudit should be able to map users and groups correctly
Reviewed by: Andy Fiddaman <andy at omniosce.org>
Reviewed by: Andrew Stormont <andyjstormont at gmail.com>
Reviewed by: Joshua M. Clulow <josh at sysmgr.org>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 7f3e7b1usr/src/uts/i86pc/dboot dboot_startkern.c

11523 i86pc: dboot_startkern.c:2046: error: comparison between pointer and integer
Reviewed by: Robert Mustacchi <robert.mustacchi at joyent.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 4f7f1d0usr/src/boot Makefile.version, usr/src/boot/sys/boot/i386/gptzfsboot zfsboot.c

11475 gptzfsboot: update parsing the option switches
Reviewed by: Andy Fiddaman <andy at omniosce.org>
Reviewed by: Robert Mustacchi <robert.mustacchi at joyent.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate efe51d0usr/src/tools/smatch/src smatch_math.c smatch_kernel_user_data.c

11506 smatch resync
Reviewed by: Yuri Pankov <yuri.pankov at nexenta.com>
Reviewed by: Toomas Soome <tsoome at me.com>
Approved by: Robert Mustacchi <rm at joyent.com>

Illumos/gate cc7e66eusr/src/boot/sys/boot/efi/loader/i386 Makefile, usr/src/boot/sys/boot/libstand/i386 Makefile

11537 loader: i386 build is missing -m32 sometimes
Reviewed by: Andrew Stormont <andyjstormont at gmail.com>
Reviewed by: Aurélien Larcher  <aurelien.larcher at gmail.com>
Reviewed by: Andy Fiddaman <andy at omniosce.org>
Approved by: Robert Mustacchi <rm at joyent.com>

Illumos/gate 4f7f6bausr/src/uts/common/fs/smbsrv smb_dfs.c

11030 SMB2 ioct dfs_get_referral returns wrong error
Reviewed by: Matt Barden <matt.barden at nexenta.com>
Reviewed by: Evan Layton <evan.layton at nexenta.com>
Approved by: Garrett D'Amore <garrett at damore.org>

Illumos/gate 959eaf3usr/src/cmd/smbsrv/smbadm smbadm.c, usr/src/man/man1m smbadm.1m

11029 smbadm man page needs updating
Reviewed by: Dan Fields <dan.fields at nexenta.com>
Reviewed by: Matt Barden <matt.barden at nexenta.com>
Approved by: Garrett D'Amore <garrett at damore.org>

Illumos/gate 9242c91usr/src/lib/smbsrv/libmlsvc/common samr_svc.c, usr/src/lib/smbsrv/libsmb/common smb_sam.c libsmb.h

11028 Need a way to add local user/group ACE from Windows
Reviewed by: Gordon Ross <gordon.ross at nexenta.com>
Reviewed by: Evan Layton <evan.layton at nexenta.com>
Approved by: Garrett D'Amore <garrett at damore.org>

Illumos/gate ef4cfbfusr/src/cmd/smbsrv/smbadm smbadm.c, usr/src/lib/smbsrv/libsmb/common smb_pwdutil.c libsmb.h

11027 method to delete local SMB users
Reviewed by: Gordon Ross <gordon.ross at nexenta.com>
Reviewed by: Evan Layton <evan.layton at nexenta.com>
Approved by: Garrett D'Amore <garrett at damore.org>

Illumos/gate 33fc94dusr/src/lib/smbsrv/libsmb/common smb_pwdutil.c

11026 Windows usernames should be treated as case insensitive
Reviewed by: Gordon Ross <gordon.ross at nexenta.com>
Reviewed by: Evan Layton <evan.layton at nexenta.com>
Approved by: Garrett D'Amore <garrett at damore.org>

Illumos/gate c7bda76usr/src/cmd/smbsrv/smbd smbd_main.c, usr/src/lib/smbsrv/libmlsvc/common smb_share.c mapfile-vers

11025 Disabling SMB server service does not change the sharestate of a smb share to 
offline
Reviewed by: Gordon Ross <gordon.ross at nexenta.com>
Reviewed by: Rob Gittins <rob.gittins at nexenta.com>
Approved by: Garrett D'Amore <garrett at damore.org>

Illumos/gate cc3780eusr/src/cmd/mdb/common/modules/smbsrv smbsrv.c, usr/src/lib/smbsrv/libmlsvc/common smb_logon.c

11024 SMB should bypass ACL traverse checking
Reviewed by: Evan Layton <evan.layton at nexenta.com>
Reviewed by: Roman Strashkin <roman.strashkin at nexenta.com>
Approved by: Garrett D'Amore <garrett at damore.org>

Illumos/gate 3e2c0c0usr/src/cmd/smbsrv/fksmbd fksmbd_kmod.c, usr/src/lib/libshare/smb libshare_smb.c

11023 SMB server min_protocol setting
Reviewed by: Gordon Ross <gordon.ross at nexenta.com>
Reviewed by: Evan Layton <evan.layton at nexenta.com>
Approved by: Garrett D'Amore <garrett at damore.org>

Illumos/gate 11eb14cusr/src/test/elf-tests/tests/linker-sets simple-src.c

11527 elf-tests simple-src.c triggers compiler errors
Reviewed by: Yuri Pankov <yuri.pankov at nexenta.com>
Reviewed by: Richard Lowe <richlowe at richlowe.net>
Reviewed by: Gergő Mihály Doma <domag02 at gmail.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate bf693dcusr/src/boot/sys/boot/efi/libefi efipart.c libefi.c, usr/src/boot/sys/boot/efi/loader main.c framebuffer.c

11516 loader.efi: replace HandleProtocol() with OpenProtocol()
Reviewed by: Yuri Pankov <yuri.pankov at nexenta.com>
Reviewed by: John Levon <john.levon at joyent.com>
Approved by: Robert Mustacchi <rm at joyent.com>

Illumos/gate 8c73292usr/src/man/man9e mac.9e, usr/src/man/man9f mac_alloc.9f

11485 mac_alloc(9F) RETURN VALUES refers to wrong function
11486 clarify mac_register(9S) life time
11487 mac(9E) should discuss the goal of aligning the IP header
Reviewed by: Toomas Soome <tsoome at me.com>
Reviewed by: Randy Fishel <randyf at sibernet.com>
Approved by: Gordon Ross <gwr at nexenta.com>

Illumos/gate d8e4595usr/src/tools/codereview lwlp.c codereview.1onbld, usr/src/tools/scripts webrev.sh webrev.1onbld

8564 developer/build/onbld shouldn't require ghostscript
Reviewed by: Alexander Pyhalov <apyhalov at gmail.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 6cb1160usr/src/cmd/stmsboot stmsboot_util.c

11434 stmsboot: NULL pointer errors
11510 stmsboot: stmsboot_util -D option validation is broken
Reviewed by: Andy Fiddaman <andy at omniosce.org>
Reviewed by: John Levon <john.levon at joyent.com>
Reviewed by: Alexander Pyhalov <apyhalov at gmail.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate ae29b8ausr/src/cmd/mdb/common/modules/smbsrv smbsrv.c

11219 mdb: smbsrv.c: error: comparison between pointer and integer
Reviewed by: Gergő Mihály Doma <domag02 at gmail.com>
Reviewed by: Juraj Lutter <juraj at lutter.sk>
Reviewed by: Andy Fiddaman <andy at omniosce.org>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 987bce4usr/src/cmd/sort/common utility.c

11431 sort: NULL pointer errors
Reviewed by: Andy Fiddaman <andy at omniosce.org>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 213b050usr/src/test/util-tests/tests/date date_test.ksh

11518 date test is incorrect
Reviewed by: Garrett D'Amore <garrett at damore.org>
Reviewed by: John Levon <levon at movementarian.org>
Reviewed by: Toomas Soome <tsoome at me.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 8072728usr/src/uts/common/io/usb usbdevs, usr/src/uts/common/io/usb/clients/usbser/usbsacm usbsacm.c

11511 usbsacm fails to open sigma designs device
Reviewed by: Joshua M. Clulow <josh at sysmgr.org>
Reviewed by: Gergő Doma <domag02 at gmail.com>
Reviewed by: Toomas Soome <tsoome at me.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 8a5bcf7usr/src/cmd/zpool zpool_vdev.c

11453 zpool: NULL pointer errors
Reviewed by: Jason Lippert <jason at glasspelican.ca>
Reviewed by: Alexander Pyhalov <apyhalov at gmail.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 94a5108usr/src/uts/common/inet/ip ip6_input.c ip_input.c, usr/src/uts/intel/ip Makefile

8903 IPPF paths have bad logic
Reviewed by: Dan McDonald <danmcd at joyent.com>
Reviewed by: John Levon <levon at movementarian.org>
Reviewed by: Gergő Doma <domag02 at gmail.com>
Approved by: Joshua M. Clulow <josh at sysmgr.org>

Illumos/gate ec82ef7usr/src/uts/common/io/usb/hcd/xhci xhci_polled.c xhci_usba.c, usr/src/uts/common/sys/usb/hcd/xhci xhci.h

11281 XHCI polled mode support for USB keyboards
Reviewed by: Robert Mustacchi <robert.mustacchi at joyent.com>
Reviewed by: Toomas Soome <tsoome at me.com>
Reviewed by: Paul Winder <Paul.Winder at wdc.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 7d724deusr/src/uts/common/io/kbtrans kbtrans_streams.c

11501 Scroll Lock translation to control sequence is patently unhelpful
Reviewed by: Yuri Pankov <yuri.pankov at nexenta.com>
Reviewed by: Andy Fiddaman <omnios at citrus-it.co.uk>
Reviewed by: Patrick Mooney <patrick.mooney at joyent.com>
Reviewed by: Toomas Soome <tsoome at me.com>
Approved by: Richard Lowe <richlowe at richlowe.net>

Illumos/gate 27aa481usr/src/cmd/truss expound.c print.c

11442 truss: NULL pointer errors
Reviewed by: Andy Fiddaman <andy at omniosce.org>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 8509e9cusr/src/cmd/fs.d mount.c, usr/src/cmd/fs.d/udfs/fsdb Makefile

11457 fs.d: NULL pointer errors
Reviewed by: Andy Fiddaman <andy at omniosce.org>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 5fe539busr/src/cmd/ldapcachemgr cachemgr_getldap.c

11381 ldapcachemgr: NULL pointer errors
Reviewed by: Peter Tribble <peter.tribble at gmail.com>
Reviewed by: Andrew Stormont <andyjstormont at gmail.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 4fcce48usr/src/lib/smbsrv/libsmb/common smb_lgrp.c, usr/src/lib/smbsrv/libsmbns/common smbns_dyndns.c

11172 smbsrv: NULL pointer errors
Reviewed by: John Levon <john.levon at joyent.com>
Reviewed by: Andrew Stormont <andyjstormont at gmail.com>
Approved by: Gordon Ross <gwr at nexenta.com>

Illumos/gate 6ccda74usr/src/lib/libzfs/common libzfs_sendrecv.c, usr/src/man/man1m zfs.1m

11282 port ZoL send/recv fixes
Portions contributed by: Jerry Jelinek <jerry.jelinek at joyent.com>
Portions contributed by: Brian Behlendorf <behlendorf1 at llnl.gov>
Portions contributed by: Paul Zuchowski <pzuchowski at datto.com>
Portions contributed by: Tom Caputi <tcaputi at datto.com>
Portions contributed by: Roman Strashkin <roman.strashkin at nexenta.com>
Reviewed by: Matthew Ahrens <mahrens at delphix.com>
Reviewed by: Olaf Faaland <faaland1 at llnl.gov>
Reviewed by: Tom Caputi <tcaputi at datto.com>
Reviewed by: Alek Pinchuk <apinchuk at datto.com>
Reviewed by: loli10K <ezomori.nozomu at gmail.com>
Reviewed by: Brian Behlendorf <behlendorf1 at llnl.gov>
Reviewed by: Paul Dagnelie <pcd at delphix.com>
Reviewed by: Jorgen Lundman <lundman at lundman.net>
Reviewed by: Richard Elling <Richard.Elling at RichardElling.com>
Reviewed by: Giuseppe Di Natale <dinatale2 at llnl.gov>
Reviewed by: George Melikov <mail at gmelikov.ru>
Reviewed by: Kody Kantor <kody.kantor at joyent.com>
Approved by: Dan McDonald <danmcd at joyent.com>